[ML] Explain Log Rate Spikes: improve the display of large groups #145609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarezmelissa87
added
release_note:skip
alvarezmelissa87
force-pushed
the
ml-aiops-group-badge-limit
branch
from
f25c171 to
78bf73a
Compare
4 tasks
|
Pinging @elastic/ml-ui (:ml) |
x-pack/plugins/aiops/public/components/spike_analysis_table/spike_analysis_table_groups.tsx
Show resolved
Hide resolved
peteharverson
approved these changes
Nov 18, 2022
There was a problem hiding this comment.
Other than the suggested edit for the label, LGTM.
One future enhancement related to this, would be to add an indicator to the expanded table rows to show if the field / value pair also appears in other groups. Will add it to #141214.
3 tasks
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
walterra
approved these changes
Nov 21, 2022
| for (const fieldName in group) { | ||
| if (group.hasOwnProperty(fieldName)) { | ||
| if (valuesBadges.length === MAX_GROUP_BADGES) break; |
There was a problem hiding this comment.
Nit: If you move that line with the break below the .push() it should break after the last necessary push instead of triggering one more loop
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 21, 2022
…astic#145609) ## Summary Related meta issue: elastic#142626 Improves the display of large groups by limiting the badges displayed to 10 and updates the +more badge. <img width="1066" alt="image (2)" src="https://user-images.githubusercontent.com/6446462/202530438-210c7005-feb6-4e76-9bbd-48eb6b26293e.png"> ### Checklist Delete any items that are not applicable to this PR. - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit 95dd368)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 22, 2022
…ps (#145609) (#145934) # Backport This will backport the following commits from `main` to `8.6`: - [[ML] Explain Log Rate Spikes: improve the display of large groups (#145609)](#145609) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Melissa Alvarez","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-11-21T20:21:14Z","message":"[ML] Explain Log Rate Spikes: improve the display of large groups (#145609)\n\n## Summary\r\n\r\nRelated meta issue: https://github.com/elastic/kibana/issues/142626\r\n\r\nImproves the display of large groups by limiting the badges displayed to\r\n10 and updates the +more badge.\r\n\r\n<img width=\"1066\" alt=\"image (2)\"\r\nsrc=\"https://user-images.githubusercontent.com/6446462/202530438-210c7005-feb6-4e76-9bbd-48eb6b26293e.png\">\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"95dd36893232d9b6802799dc27ca911c59dee629","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","cosmetic","release_note:skip","Feature:ML/AIOps","v8.6.0","v8.7.0"],"number":145609,"url":"https://github.com/elastic/kibana/pull/145609","mergeCommit":{"message":"[ML] Explain Log Rate Spikes: improve the display of large groups (#145609)\n\n## Summary\r\n\r\nRelated meta issue: https://github.com/elastic/kibana/issues/142626\r\n\r\nImproves the display of large groups by limiting the badges displayed to\r\n10 and updates the +more badge.\r\n\r\n<img width=\"1066\" alt=\"image (2)\"\r\nsrc=\"https://user-images.githubusercontent.com/6446462/202530438-210c7005-feb6-4e76-9bbd-48eb6b26293e.png\">\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"95dd36893232d9b6802799dc27ca911c59dee629"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145609","number":145609,"mergeCommit":{"message":"[ML] Explain Log Rate Spikes: improve the display of large groups (#145609)\n\n## Summary\r\n\r\nRelated meta issue: https://github.com/elastic/kibana/issues/142626\r\n\r\nImproves the display of large groups by limiting the badges displayed to\r\n10 and updates the +more badge.\r\n\r\n<img width=\"1066\" alt=\"image (2)\"\r\nsrc=\"https://user-images.githubusercontent.com/6446462/202530438-210c7005-feb6-4e76-9bbd-48eb6b26293e.png\">\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [x] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"95dd36893232d9b6802799dc27ca911c59dee629"}}]}] BACKPORT--> Co-authored-by: Melissa Alvarez <[email protected]>
3 tasks
![https://user-images.githubusercontent.com/6446462/202530438-210c7005-feb6-4e76-9bbd-48eb6b26293e.png\">\r\n\r\n\r\n###](https://user-images.githubusercontent.com/6446462/202530438-210c7005-feb6-4e76-9bbd-48eb6b26293e.png\">\r\n\r\n\r\n###){kind=link}
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related meta issue: #142626
Improves the display of large groups by limiting the badges displayed to 10 and updates the +more badge.
Checklist
Delete any items that are not applicable to this PR.