[Controls] fix time slider play button display=fill property not being respected #145417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
Team:Presentation
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
|
@elasticmachine merge upstream |
ryankeairns
approved these changes
Nov 16, 2022
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
ThomThomson
approved these changes
Nov 16, 2022
kibanamachine
pushed a commit
that referenced
this pull request
Nov 16, 2022
…g respected (#145417) resolves #145301 Steps to test * create new dashboard * Add time slider control * verify play toggle button has primary color background <img width="600" alt="Screen Shot 2022-11-16 at 9 56 00 AM" src="https://user-images.githubusercontent.com/373691/202244344-e4ec6f45-9d87-4819-96a6-dc47b551b213.png"> Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit de39dba)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
kibanamachine
added a commit
that referenced
this pull request
Nov 16, 2022
…t being respected (#145417) (#145447) # Backport This will backport the following commits from `main` to `8.6`: - [[Controls] fix time slider play button display=fill property not being respected (#145417)](#145417) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nathan Reese","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-11-16T20:19:53Z","message":"[Controls] fix time slider play button display=fill property not being respected (#145417)\n\nresolves https://github.com/elastic/kibana/issues/145301\r\n\r\nSteps to test\r\n* create new dashboard\r\n* Add time slider control\r\n* verify play toggle button has primary color background\r\n\r\n<img width=\"600\" alt=\"Screen Shot 2022-11-16 at 9 56 00 AM\"\r\nsrc=\"https://user-images.githubusercontent.com/373691/202244344-e4ec6f45-9d87-4819-96a6-dc47b551b213.png\">\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"de39dba2c49959293a970b271a588269ba11ed0e","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","auto-backport","v8.6.0","v8.7.0"],"number":145417,"url":"https://github.com/elastic/kibana/pull/145417","mergeCommit":{"message":"[Controls] fix time slider play button display=fill property not being respected (#145417)\n\nresolves https://github.com/elastic/kibana/issues/145301\r\n\r\nSteps to test\r\n* create new dashboard\r\n* Add time slider control\r\n* verify play toggle button has primary color background\r\n\r\n<img width=\"600\" alt=\"Screen Shot 2022-11-16 at 9 56 00 AM\"\r\nsrc=\"https://user-images.githubusercontent.com/373691/202244344-e4ec6f45-9d87-4819-96a6-dc47b551b213.png\">\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"de39dba2c49959293a970b271a588269ba11ed0e"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145417","number":145417,"mergeCommit":{"message":"[Controls] fix time slider play button display=fill property not being respected (#145417)\n\nresolves https://github.com/elastic/kibana/issues/145301\r\n\r\nSteps to test\r\n* create new dashboard\r\n* Add time slider control\r\n* verify play toggle button has primary color background\r\n\r\n<img width=\"600\" alt=\"Screen Shot 2022-11-16 at 9 56 00 AM\"\r\nsrc=\"https://user-images.githubusercontent.com/373691/202244344-e4ec6f45-9d87-4819-96a6-dc47b551b213.png\">\r\n\r\nCo-authored-by: Kibana Machine <[email protected]>","sha":"de39dba2c49959293a970b271a588269ba11ed0e"}}]}] BACKPORT--> Co-authored-by: Nathan Reese <[email protected]>
![https://user-images.githubusercontent.com/373691/202244344-e4ec6f45-9d87-4819-96a6-dc47b551b213.png\">\r\n\r\nCo-authored-by](https://user-images.githubusercontent.com/373691/202244344-e4ec6f45-9d87-4819-96a6-dc47b551b213.png\">\r\n\r\nCo-authored-by){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #145301
Steps to test