[RAM] Allow more tags in the filter for rule list table #145413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XavierM
added
bug
|
Pinging @elastic/response-ops (Team:ResponseOps) |
jcger
approved these changes
Nov 16, 2022
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @XavierM |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 16, 2022
## Summary Allow more tags in the filter for the rule list table. This an easy win before creating a specific API to get more tags for the filter an dit will help this [SDH](elastic/sdh-kibana#3281) To make sure that this change won't impact performance we test it the aggregation with GB of data and we did not see any reason to worry about it. (cherry picked from commit b536a16)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 16, 2022
… (#145451) # Backport This will backport the following commits from `main` to `8.6`: - [[RAM] Allow more tags in the filter for rule list table (#145413)](#145413) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Xavier Mouligneau","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-11-16T20:55:18Z","message":"[RAM] Allow more tags in the filter for rule list table (#145413)\n\n## Summary\r\n\r\nAllow more tags in the filter for the rule list table. This an easy win\r\nbefore creating a specific API to get more tags for the filter an dit\r\nwill help this [SDH](https://github.com/elastic/sdh-kibana/issues/3281)\r\n\r\nTo make sure that this change won't impact performance we test it the\r\naggregation with GB of data and we did not see any reason to worry about\r\nit.","sha":"b536a16d7be5ce26dcda48e29127d592736cee46","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","impact:low","Team:ResponseOps","v8.6.0","v8.7.0"],"number":145413,"url":"https://github.com/elastic/kibana/pull/145413","mergeCommit":{"message":"[RAM] Allow more tags in the filter for rule list table (#145413)\n\n## Summary\r\n\r\nAllow more tags in the filter for the rule list table. This an easy win\r\nbefore creating a specific API to get more tags for the filter an dit\r\nwill help this [SDH](https://github.com/elastic/sdh-kibana/issues/3281)\r\n\r\nTo make sure that this change won't impact performance we test it the\r\naggregation with GB of data and we did not see any reason to worry about\r\nit.","sha":"b536a16d7be5ce26dcda48e29127d592736cee46"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145413","number":145413,"mergeCommit":{"message":"[RAM] Allow more tags in the filter for rule list table (#145413)\n\n## Summary\r\n\r\nAllow more tags in the filter for the rule list table. This an easy win\r\nbefore creating a specific API to get more tags for the filter an dit\r\nwill help this [SDH](https://github.com/elastic/sdh-kibana/issues/3281)\r\n\r\nTo make sure that this change won't impact performance we test it the\r\naggregation with GB of data and we did not see any reason to worry about\r\nit.","sha":"b536a16d7be5ce26dcda48e29127d592736cee46"}}]}] BACKPORT--> Co-authored-by: Xavier Mouligneau <[email protected]>
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
XavierM
added a commit
to XavierM/kibana
that referenced
this pull request
Nov 18, 2022
## Summary Allow more tags in the filter for the rule list table. This an easy win before creating a specific API to get more tags for the filter an dit will help this [SDH](elastic/sdh-kibana#3281) To make sure that this change won't impact performance we test it the aggregation with GB of data and we did not see any reason to worry about it. (cherry picked from commit b536a16)
XavierM
added a commit
that referenced
this pull request
Nov 18, 2022
… (#145779) # Backport This will backport the following commits from `main` to `8.5`: - [[RAM] Allow more tags in the filter for rule list table (#145413)](#145413) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Xavier Mouligneau","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-11-16T20:55:18Z","message":"[RAM] Allow more tags in the filter for rule list table (#145413)\n\n## Summary\r\n\r\nAllow more tags in the filter for the rule list table. This an easy win\r\nbefore creating a specific API to get more tags for the filter an dit\r\nwill help this [SDH](https://github.com/elastic/sdh-kibana/issues/3281)\r\n\r\nTo make sure that this change won't impact performance we test it the\r\naggregation with GB of data and we did not see any reason to worry about\r\nit.","sha":"b536a16d7be5ce26dcda48e29127d592736cee46","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","impact:low","Team:ResponseOps","v8.6.0","v8.7.0","v8.5.2"],"number":145413,"url":"https://github.com/elastic/kibana/pull/145413","mergeCommit":{"message":"[RAM] Allow more tags in the filter for rule list table (#145413)\n\n## Summary\r\n\r\nAllow more tags in the filter for the rule list table. This an easy win\r\nbefore creating a specific API to get more tags for the filter an dit\r\nwill help this [SDH](https://github.com/elastic/sdh-kibana/issues/3281)\r\n\r\nTo make sure that this change won't impact performance we test it the\r\naggregation with GB of data and we did not see any reason to worry about\r\nit.","sha":"b536a16d7be5ce26dcda48e29127d592736cee46"}},"sourceBranch":"main","suggestedTargetBranches":["8.5"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/145451","number":145451,"state":"MERGED","mergeCommit":{"sha":"2fb77778e231bb3a946ea19c06b64af512177a8c","message":"[8.6] [RAM] Allow more tags in the filter for rule list table (#145413) (#145451)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.6`:\n- [[RAM] Allow more tags in the filter for rule list table\n(#145413)](https://github.com/elastic/kibana/pull/145413)\n\n<!--- Backport version: 8.9.7 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Xavier\nMouligneau\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2022-11-16T20:55:18Z\",\"message\":\"[RAM]\nAllow more tags in the filter for rule list table (#145413)\\n\\n##\nSummary\\r\\n\\r\\nAllow more tags in the filter for the rule list table.\nThis an easy win\\r\\nbefore creating a specific API to get more tags for\nthe filter an dit\\r\\nwill help this\n[SDH](https://github.com/elastic/sdh-kibana/issues/3281)\\r\\n\\r\\nTo make\nsure that this change won't impact performance we test it\nthe\\r\\naggregation with GB of data and we did not see any reason to\nworry\nabout\\r\\nit.\",\"sha\":\"b536a16d7be5ce26dcda48e29127d592736cee46\",\"branchLabelMapping\":{\"^v8.7.0$\":\"main\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"bug\",\"release_note:skip\",\"impact:low\",\"Team:ResponseOps\",\"v8.6.0\",\"v8.7.0\"],\"number\":145413,\"url\":\"https://github.com/elastic/kibana/pull/145413\",\"mergeCommit\":{\"message\":\"[RAM]\nAllow more tags in the filter for rule list table (#145413)\\n\\n##\nSummary\\r\\n\\r\\nAllow more tags in the filter for the rule list table.\nThis an easy win\\r\\nbefore creating a specific API to get more tags for\nthe filter an dit\\r\\nwill help this\n[SDH](https://github.com/elastic/sdh-kibana/issues/3281)\\r\\n\\r\\nTo make\nsure that this change won't impact performance we test it\nthe\\r\\naggregation with GB of data and we did not see any reason to\nworry\nabout\\r\\nit.\",\"sha\":\"b536a16d7be5ce26dcda48e29127d592736cee46\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.6\"],\"targetPullRequestStates\":[{\"branch\":\"8.6\",\"label\":\"v8.6.0\",\"labelRegex\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"},{\"branch\":\"main\",\"label\":\"v8.7.0\",\"labelRegex\":\"^v8.7.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/145413\",\"number\":145413,\"mergeCommit\":{\"message\":\"[RAM]\nAllow more tags in the filter for rule list table (#145413)\\n\\n##\nSummary\\r\\n\\r\\nAllow more tags in the filter for the rule list table.\nThis an easy win\\r\\nbefore creating a specific API to get more tags for\nthe filter an dit\\r\\nwill help this\n[SDH](https://github.com/elastic/sdh-kibana/issues/3281)\\r\\n\\r\\nTo make\nsure that this change won't impact performance we test it\nthe\\r\\naggregation with GB of data and we did not see any reason to\nworry\nabout\\r\\nit.\",\"sha\":\"b536a16d7be5ce26dcda48e29127d592736cee46\"}}]}]\nBACKPORT-->\n\nCo-authored-by: Xavier Mouligneau <[email protected]>"}},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145413","number":145413,"mergeCommit":{"message":"[RAM] Allow more tags in the filter for rule list table (#145413)\n\n## Summary\r\n\r\nAllow more tags in the filter for the rule list table. This an easy win\r\nbefore creating a specific API to get more tags for the filter an dit\r\nwill help this [SDH](https://github.com/elastic/sdh-kibana/issues/3281)\r\n\r\nTo make sure that this change won't impact performance we test it the\r\naggregation with GB of data and we did not see any reason to worry about\r\nit.","sha":"b536a16d7be5ce26dcda48e29127d592736cee46"}},{"branch":"8.5","label":"v8.5.2","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow more tags in the filter for the rule list table. This an easy win before creating a specific API to get more tags for the filter an dit will help this SDH
To make sure that this change won't impact performance we test it the aggregation with GB of data and we did not see any reason to worry about it.