Don't show "You have not been authorized to create any Rule types" message while request to get rule types is in flight #145407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
XavierM
approved these changes
Nov 16, 2022
XavierM
added
v8.6.0
release_note:skip
|
Pinging @elastic/response-ops (Team:ResponseOps) |
|
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 17, 2022
…ssage while request to get rule types is in flight (elastic#145407) (cherry picked from commit e01649e)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 17, 2022
…es" message while request to get rule types is in flight (#145407) (#145506) # Backport This will backport the following commits from `main` to `8.6`: - [Don't show "You have not been authorized to create any Rule types" message while request to get rule types is in flight (#145407)](#145407) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Coen Warmer","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-11-17T07:19:07Z","message":"Don't show \"You have not been authorized to create any Rule types\" message while request to get rule types is in flight (#145407)","sha":"e01649e7b23d9bb0b855b2ba2081ae72cc49f815","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","Team: Actionable Observability","v8.6.0","v8.7.0"],"number":145407,"url":"https://github.com/elastic/kibana/pull/145407","mergeCommit":{"message":"Don't show \"You have not been authorized to create any Rule types\" message while request to get rule types is in flight (#145407)","sha":"e01649e7b23d9bb0b855b2ba2081ae72cc49f815"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145407","number":145407,"mergeCommit":{"message":"Don't show \"You have not been authorized to create any Rule types\" message while request to get rule types is in flight (#145407)","sha":"e01649e7b23d9bb0b855b2ba2081ae72cc49f815"}}]}] BACKPORT--> Co-authored-by: Coen Warmer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #145396.
Summary
This PR makes sure
/api/alerting/rule_typesis done loading before it shows the available rules. Therefore, the UI will not default anymore to the "You have not been authorized to create any Rule types" message while the request is in flight.Screen.Recording.2022-11-16.at.17.13.08.mov