Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enterprise Search] Only show specifically enabled filtering features #145383

Conversation

sphilipse
Copy link
Member

@sphilipse sphilipse commented Nov 16, 2022

This hides a specific filtering feature from the user if it's not enabled for the connector they're using.

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #27 / GlobalSearch API GlobalSearch providers SavedObject provider can search for data views

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.0MB 2.0MB +197.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 108 113 +5
securitySolution 441 447 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 67 73 +6
osquery 109 115 +6
securitySolution 518 524 +6
total +20

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sphilipse sphilipse merged commit ed14ba0 into elastic:main Nov 17, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 17, 2022
…elastic#145383)

This hides a specific filtering feature from the user if it's not
enabled for the connector they're using.

(cherry picked from commit ed14ba0)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.6

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 17, 2022
…atures (#145383) (#145545)

# Backport

This will backport the following commits from `main` to `8.6`:
- [[Enterprise Search] Only show specifically enabled filtering features
(#145383)](#145383)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sander
Philipse","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-11-17T11:46:00Z","message":"[Enterprise
Search] Only show specifically enabled filtering features
(#145383)\n\nThis hides a specific filtering feature from the user if
it's not\r\nenabled for the connector they're
using.","sha":"ed14ba0e29ae17f176d8fc87db4ccf4a1edf73a5","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:EnterpriseSearch","v8.6.0","v8.7.0"],"number":145383,"url":"https://github.com/elastic/kibana/pull/145383","mergeCommit":{"message":"[Enterprise
Search] Only show specifically enabled filtering features
(#145383)\n\nThis hides a specific filtering feature from the user if
it's not\r\nenabled for the connector they're
using.","sha":"ed14ba0e29ae17f176d8fc87db4ccf4a1edf73a5"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145383","number":145383,"mergeCommit":{"message":"[Enterprise
Search] Only show specifically enabled filtering features
(#145383)\n\nThis hides a specific filtering feature from the user if
it's not\r\nenabled for the connector they're
using.","sha":"ed14ba0e29ae17f176d8fc87db4ccf4a1edf73a5"}}]}]
BACKPORT-->

Co-authored-by: Sander Philipse <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants