-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enterprise Search] Only show specifically enabled filtering features #145383
Merged
sphilipse
merged 1 commit into
elastic:main
from
sphilipse:ent-search-fix-only-show-filtering-feature-enabled
Nov 17, 2022
Merged
[Enterprise Search] Only show specifically enabled filtering features #145383
sphilipse
merged 1 commit into
elastic:main
from
sphilipse:ent-search-fix-only-show-filtering-feature-enabled
Nov 17, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
TattdCodeMonkey
approved these changes
Nov 16, 2022
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 17, 2022
…elastic#145383) This hides a specific filtering feature from the user if it's not enabled for the connector they're using. (cherry picked from commit ed14ba0)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 17, 2022
…atures (#145383) (#145545) # Backport This will backport the following commits from `main` to `8.6`: - [[Enterprise Search] Only show specifically enabled filtering features (#145383)](#145383) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sander Philipse","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-11-17T11:46:00Z","message":"[Enterprise Search] Only show specifically enabled filtering features (#145383)\n\nThis hides a specific filtering feature from the user if it's not\r\nenabled for the connector they're using.","sha":"ed14ba0e29ae17f176d8fc87db4ccf4a1edf73a5","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","Team:EnterpriseSearch","v8.6.0","v8.7.0"],"number":145383,"url":"https://github.com/elastic/kibana/pull/145383","mergeCommit":{"message":"[Enterprise Search] Only show specifically enabled filtering features (#145383)\n\nThis hides a specific filtering feature from the user if it's not\r\nenabled for the connector they're using.","sha":"ed14ba0e29ae17f176d8fc87db4ccf4a1edf73a5"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145383","number":145383,"mergeCommit":{"message":"[Enterprise Search] Only show specifically enabled filtering features (#145383)\n\nThis hides a specific filtering feature from the user if it's not\r\nenabled for the connector they're using.","sha":"ed14ba0e29ae17f176d8fc87db4ccf4a1edf73a5"}}]}] BACKPORT--> Co-authored-by: Sander Philipse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hides a specific filtering feature from the user if it's not enabled for the connector they're using.