Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enterprise Search] Match simulate pipeline features with stack management #145275

Merged
merged 7 commits into from
Nov 15, 2022

Conversation

efegurkan
Copy link
Member

Summary

Adds features to test pipeline with an existing document from the index.
Also updated the text to give consistent messages across the other parts of the kibana

Screen.Recording.2022-11-15.at.17.53.41.mov

Release note

Adds the ability to test Ingest pipelines with a document from the same index.

Checklist

Delete any items that are not applicable to this PR.

@efegurkan efegurkan added release_note:feature Makes this part of the condensed release notes Team:EnterpriseSearch v8.6.0 labels Nov 15, 2022
@efegurkan efegurkan requested a review from a team November 15, 2022 16:58
Copy link
Contributor

@TattdCodeMonkey TattdCodeMonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, likely to have some conflicts between this and #145037
Whichever merges first the other one will need to get rebased most likely.

@efegurkan efegurkan enabled auto-merge (squash) November 15, 2022 19:11
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
enterpriseSearch 1861 1862 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
enterpriseSearch 2.0MB 2.0MB +2.2KB
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 108 113 +5
securitySolution 441 447 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 67 73 +6
osquery 109 115 +6
securitySolution 518 524 +6
total +20

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@efegurkan efegurkan merged commit 12e6b2b into elastic:main Nov 15, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 15, 2022
@efegurkan efegurkan deleted the make-simulate-consistent branch November 15, 2022 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:feature Makes this part of the condensed release notes Team:EnterpriseSearch v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants