[Enterprise Search] Add cron scheduling support to Kibana #145241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byronhulcher
added
release_note:skip
sphilipse
approved these changes
Nov 15, 2022
| } | ||
| ) | ||
| ); | ||
| // actions.clearCrawlSchedule(); |
There was a problem hiding this comment.
nitpick(non-blocking): Can this be removed?
| } catch (e) { | ||
| // A 404 is expected and means the user has no crawl schedule to delete | ||
| if (e.response?.status === 404) { | ||
| actions.clearCrawlSchedule(); | ||
| // actions.clearCrawlSchedule(); |
| ) | ||
| ); | ||
| actions.setCrawlSchedule(crawlScheduleServerToClient(crawlSchedule)); | ||
| // flashSuccessToast( |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
kibanamachine
added
v8.6.0
backport:skip
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
byronhulcher
added a commit
that referenced
this pull request
Nov 16, 2022
) (#145445) # Backport This will backport the following commits from `main` to `8.6`: - [[Enterprise Search] Add cron scheduling support to Kibana (#145241)](#145241) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Byron Hulcher","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-11-16T16:57:51Z","message":"[Enterprise Search] Add cron scheduling support to Kibana (#145241)","sha":"1192e4f375420ef46cf73008f9e78229af62f86c","branchLabelMapping":{"^v8.6.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","Team:EnterpriseSearch","v8.6.0"],"number":145241,"url":"https://github.com/elastic/kibana/pull/145241","mergeCommit":{"message":"[Enterprise Search] Add cron scheduling support to Kibana (#145241)","sha":"1192e4f375420ef46cf73008f9e78229af62f86c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.6.0","labelRegex":"^v8.6.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/145241","number":145241,"mergeCommit":{"message":"[Enterprise Search] Add cron scheduling support to Kibana (#145241)","sha":"1192e4f375420ef46cf73008f9e78229af62f86c"}}]}] BACKPORT-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds new UX to the Search Index view's Scheduling tab for crawler indices, based on the same view/tab for connector indices. Users can select between cron and interval scheduling, and modify settings for each. Cron schedules are still stored in the connector configuration document.
scheduling.mov
Some notes:
CronEditorcomponent didn't support that. With feature freeze looming I made a pragmatic decision to straight up copy/paste the component into the Enterprise Search directory, and add thedisabledflag to that component and its child components. I take no pleasure in reporting this. This side-steps engaging with the ES UI team via a PR into their original component. I had to copy the whole directory, rather than just the files I needed to modify, because ES UI is a private directory that our tooling will not allow me to import from (largely to prevent exactly what I was attempting to do here) I will follow-up with a PR into ES UI after feature freeze.Checklist
Delete any items that are not applicable to this PR.