Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Edit Tines connector #145168

Merged
merged 1 commit into from
Nov 15, 2022
Merged

[DOCS] Edit Tines connector #145168

merged 1 commit into from
Nov 15, 2022

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Nov 14, 2022

Summary

Relates to elastic/security-docs#2689

This PR edits the Tines connector documentation. In particular, it:

  • Fixes the broken images
  • Fixes the nesting of the page so that it aligns with the other connectors
  • Replaces "execution" terminology
  • Makes it clearer when a link targets third-party documentation

@lcawl lcawl added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting docs Team:Threat Hunting Security Solution Threat Hunting Team v8.6.0 labels Nov 14, 2022
@github-actions
Copy link
Contributor

Documentation preview:

@lcawl lcawl marked this pull request as ready for review November 14, 2022 19:40
@lcawl lcawl requested review from a team as code owners November 14, 2022 19:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

szabosteve
szabosteve approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lcawl lcawl merged commit 413e813 into elastic:main Nov 15, 2022
@lcawl lcawl deleted the fix-tines-connector branch November 15, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szabosteve szabosteve szabosteve approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting docs release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lcawl @elasticmachine @szabosteve