Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Synthetics] Added total step duration #144993

Merged
merged 4 commits into from
Nov 14, 2022

Conversation

shahzad31
Copy link
Contributor

Summary

Added total step duration on Step details page below donut breakdown

image

@shahzad31 shahzad31 requested a review from a team as a code owner November 10, 2022 15:31
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Nov 10, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes v8.6.0 labels Nov 10, 2022
@hbharding
Copy link
Contributor

So sorry to do this Shahzad - @dominiqueclarke pointed out to me that the "total step duration" does not equal the sum of network event timings, so I'm worried showing this number here will be confusing or misleading. I updated the design to move this stat into the "Metrics" panel. Can you move this stat to the area highlighted in pink below. Ideally this stat can use the comparison to last test run feature.
image

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 487.5KB 487.5KB +19.0B
synthetics 1.1MB 1.1MB +476.0B
total +495.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 108 113 +5
securitySolution 441 447 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 67 73 +6
osquery 109 115 +6
securitySolution 518 524 +6
total +20

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@awahab07 awahab07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahzad31 shahzad31 merged commit e580f23 into elastic:main Nov 14, 2022
@shahzad31 shahzad31 deleted the total-step-duration branch November 14, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants