[Security Solution] [Exceptions] Adds a new react route for viewing details about an individual exception list #144754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-ref HEAD~1..HEAD --fix'
… list-details-route
dhurley14
changed the title
dhurley14
added
review
release_note:skip
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
kevinlog
reviewed
Nov 8, 2022
paul-tavares
reviewed
Nov 8, 2022
...ic/applications/fleet/components/fleet_server_instructions/hooks/use_latest_fleet_servers.ts
Outdated
Show resolved
Hide resolved
juliaElastic
approved these changes
Nov 9, 2022
… shared lists and the endpoint exception list on the manage shared exception lists page
dhurley14
commented
Nov 10, 2022
Comment on lines
+18
to
+25
| return ALL_ENDPOINT_ARTIFACT_LIST_IDS.includes(listId) ? ( | ||
| <NotFoundPage /> | ||
| ) : ( | ||
| <EuiTitle> | ||
| <h2>{listId}</h2> | ||
| </EuiTitle> | ||
| ); | ||
| }); |
There was a problem hiding this comment.
@paul-tavares How does this look for a start?
dhurley14
commented
Nov 10, 2022
Comment on lines
+88
to
+89
| types: [ExceptionListTypeEnum.DETECTION, ExceptionListTypeEnum.ENDPOINT], | ||
| }); |
There was a problem hiding this comment.
@WafaaNasr @peluja1012 This PR adds a filter to only display shared lists and the endpoint list.
WafaaNasr
reviewed
Nov 10, 2022
| onClick={goToExceptionDetail} | ||
| > | ||
| {listName} | ||
| </EuiLink>{' '} |
There was a problem hiding this comment.
{' '} I think this space is unwanted :D
There was a problem hiding this comment.
ah interesting - not sure how that got in there. Thanks!
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @dhurley14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Clicking on the link for an individual exception list will route users to the detail view. Currently only displays the list id on the detail view.