Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Add docs for package verification GPG key #144707

Merged
merged 3 commits into from
Nov 7, 2022

Conversation

kpollich
Copy link
Member

@kpollich kpollich commented Nov 7, 2022

Summary

Document the xpack.fleet.packageVerification.gpgKeyPath setting in the Fleet settings docs.

@kpollich kpollich added release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team labels Nov 7, 2022
@kpollich kpollich requested a review from dedemorton November 7, 2022 14:28
@kpollich kpollich self-assigned this Nov 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2022

Documentation preview:

Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpollich kpollich merged commit 4eeeb0d into elastic:main Nov 7, 2022
@kpollich kpollich deleted the fleet/add-gpg-docs branch November 7, 2022 19:25
@kibanamachine kibanamachine added v8.6.0 backport:skip This commit does not require backporting labels Nov 7, 2022
@dedemorton
Copy link
Contributor

@kpollich Will this be backported to 8.5, too?

@kpollich kpollich added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:skip This commit does not require backporting labels Nov 7, 2022
kpollich added a commit to kpollich/kibana that referenced this pull request Nov 8, 2022
* Add docs for package verification GPG key

* Update fleet-settings.asciidoc

* Update docs/settings/fleet-settings.asciidoc

Co-authored-by: DeDe Morton <[email protected]>

Co-authored-by: DeDe Morton <[email protected]>
(cherry picked from commit 4eeeb0d)
@kpollich
Copy link
Member Author

kpollich commented Nov 8, 2022

💚 All backports created successfully

Status Branch Result
8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 10, 2022
kpollich added a commit that referenced this pull request Nov 10, 2022
…44815)

# Backport

This will backport the following commits from `main` to `8.5`:
- [[Fleet] Add docs for package verification GPG key
(#144707)](#144707)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Kyle
Pollich","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-11-07T19:25:05Z","message":"[Fleet]
Add docs for package verification GPG key (#144707)\n\n* Add docs for
package verification GPG key\r\n\r\n* Update
fleet-settings.asciidoc\r\n\r\n* Update
docs/settings/fleet-settings.asciidoc\r\n\r\nCo-authored-by: DeDe Morton
<[email protected]>\r\n\r\nCo-authored-by: DeDe Morton
<[email protected]>","sha":"4eeeb0db8f94b3b7adc692917e291d466e3dc653","branchLabelMapping":{"^v8.6.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","backport:prev-minor","v8.6.0"],"number":144707,"url":"https://github.com/elastic/kibana/pull/144707","mergeCommit":{"message":"[Fleet]
Add docs for package verification GPG key (#144707)\n\n* Add docs for
package verification GPG key\r\n\r\n* Update
fleet-settings.asciidoc\r\n\r\n* Update
docs/settings/fleet-settings.asciidoc\r\n\r\nCo-authored-by: DeDe Morton
<[email protected]>\r\n\r\nCo-authored-by: DeDe Morton
<[email protected]>","sha":"4eeeb0db8f94b3b7adc692917e291d466e3dc653"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.6.0","labelRegex":"^v8.6.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/144707","number":144707,"mergeCommit":{"message":"[Fleet]
Add docs for package verification GPG key (#144707)\n\n* Add docs for
package verification GPG key\r\n\r\n* Update
fleet-settings.asciidoc\r\n\r\n* Update
docs/settings/fleet-settings.asciidoc\r\n\r\nCo-authored-by: DeDe Morton
<[email protected]>\r\n\r\nCo-authored-by: DeDe Morton
<[email protected]>","sha":"4eeeb0db8f94b3b7adc692917e291d466e3dc653"}}]}]
BACKPORT-->
@kibanamachine kibanamachine added v8.5.1 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.5.1 v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants