Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] [Controls] Change wording of exists setting tooltip #144652

Merged

Conversation

Heenawter
Copy link
Contributor

@Heenawter Heenawter commented Nov 4, 2022

Summary

Refer to #143762 (comment) for context.

This PR changes the wording of the exists query toggle tooltip to be more descriptive:

Nov-07-2022 09-20-34

Checklist

For maintainers

@Heenawter Heenawter added Feature:Dashboard Dashboard related features Feature:Input Control Input controls visualization Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Project:Controls v8.6.0 labels Nov 4, 2022
@Heenawter Heenawter self-assigned this Nov 4, 2022
@Heenawter Heenawter force-pushed the fix-wording-of-exists-tooltip_2022-10-04 branch from 6bae8c5 to e41a6ca Compare November 7, 2022 16:24
@Heenawter Heenawter added the ui-copy Review of UI copy with docs team is recommended label Nov 7, 2022
@Heenawter Heenawter requested a review from KOTungseth November 7, 2022 17:12
@Heenawter Heenawter marked this pull request as ready for review November 7, 2022 17:12
@Heenawter Heenawter requested a review from a team as a code owner November 7, 2022 17:12
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

Copy link
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy change LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
controls 21.9KB 22.0KB +44.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 58 64 +6
osquery 108 113 +5
securitySolution 440 446 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 66 72 +6
osquery 109 115 +6
securitySolution 517 523 +6
total +20

History

  • 💚 Build #85615 succeeded 6bae8c5a6224db21c11de60eef71c5cdd3b318fb

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @Heenawter

@Heenawter Heenawter requested review from a team and removed request for KOTungseth November 7, 2022 19:28
Copy link
Contributor

@KOTungseth KOTungseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Heenawter Heenawter merged commit a050c5b into elastic:main Nov 7, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Nov 7, 2022
@Heenawter Heenawter deleted the fix-wording-of-exists-tooltip_2022-10-04 branch November 7, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Dashboard Dashboard related features Feature:Input Control Input controls visualization impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Project:Controls release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas ui-copy Review of UI copy with docs team is recommended v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants