[Security Solution] [Exceptions] Adds options to create a shared exception list and to create a single item from the manage exceptions view #144575

dhurley14 · 2022-11-03T22:48:19Z

Summary

Adds options to create a shared exception list and creating a single item to be attached to multiple rules default lists or to add it to shared lists.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios

… title of breadcrumb

…s-view

…ion perPage property to 20

…ilderProps

…all-lists

…st to match outcome where we are overwriting a list on import and the list item ids already exist so there should be no error when overwriting

…all-lists

WafaaNasr · 2022-11-07T17:32:29Z

packages/kbn-securitysolution-io-ts-list-types/src/common/exception_list/index.ts

-  DETECTION = 'detection',
-  RULE_DEFAULT = 'rule_default',
+  DETECTION = 'detection', // shared exception list type
+  RULE_DEFAULT = 'rule_default', // rule default, cannot be shared


...ugins/security_solution/public/exceptions/manage_exceptions/create_shared_exception_list.tsx

x-pack/plugins/security_solution/public/exceptions/manage_exceptions/use_create_shared_list.tsx

WafaaNasr

Thanks for the great work, and the explanations! ❤️
Added some comments but none of them will stop the merge!

…ates code to use a form object and use only one onchange fn

…to more-exceptions-work

kibana-ci · 2022-11-08T23:41:23Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 1f44dc8

Failed CI Steps

Security Solution Tests #1

Test Failures

[job] [logs] Security Solution Tests #1 / Cases Creates a new case with timeline and opens the timeline

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`securitySolution`	3204	3206	+2

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`lists`	165.7KB	165.8KB	+125.0B
`securitySolution`	9.6MB	9.6MB	+5.1KB
total			+5.2KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`securitySolution`	50.6KB	50.6KB	+58.0B

Unknown metric groups

ESLint disabled in files

id	before	after	diff
`osquery`	1	2	+1

ESLint disabled line counts

id	before	after	diff
`enterpriseSearch`	19	21	+2
`fleet`	59	65	+6
`osquery`	108	113	+5
`securitySolution`	440	446	+6
total			+19

Total ESLint disabled count

id	before	after	diff
`enterpriseSearch`	20	22	+2
`fleet`	67	73	+6
`osquery`	109	115	+6
`securitySolution`	517	523	+6
total			+20

History

💚 Build #85965 succeeded 2b24a88
💔 Build #85930 failed 48c2ade
💚 Build #85612 succeeded dc7c006
💔 Build #85606 failed 0c5081c
💔 Build #85591 failed 17ecc55
💔 Build #85336 failed d612b00

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dhurley14

YulNaumenko

LGTM!

* main: [Lens] Rearrange options (elastic#144891) [Actionable Observability] Integrate alert search bar on rule details page (elastic#144718) [Security Solution] [Exceptions] Adds options to create a shared exception list and to create a single item from the manage exceptions view (elastic#144575) [Actionable Observability] Add context.alertDetailsUrl to connector template for Uptime > Monitor status & Uptime TLS rules (elastic#144740) [Security Solution] [Feat] Add Bulk Events to Timeline. (elastic#142737) [TIP] Env specific cypress config (elastic#144894) skip flaky suite (elastic#144885) [Enterprise Search] Fixes Search Index page to go blank when connection lost (elastic#144022) [Cloud Posture] track findings pages (elastic#144822) [ContentManagement] Inspector flyout (elastic#144240) [Cloud Posture] Dashboard Redesign - data counter cards (elastic#144565) [TIP] Run e2e pipeline on CI (elastic#144776) [Guided onboarding] Config updates for the Security guide (elastic#144844) Cleanup unused code for claiming tasks by id (elastic#144408) Ping the response-ops team whenever a new connector type is registered (elastic#144736)

dhurley14 and others added 30 commits August 31, 2022 18:19

initial work

fd62185

adds exception list import button + flyout, updates title of page and…

cfebdbe

… title of breadcrumb

working import

36fc5b9

merge with main

0ac8f00

import list + override or as new list

9647b1f

fix type failures (still some warnings present) and general code cleanup

2465249

Merge remote-tracking branch 'upstream/main' into exceptions-all-list…

c2002ea

…s-view

adds delete action to actions menu bar

2a2fa40

WIP - adding overflow actions

5d8b600

Merge branch 'main' into exceptions-all-lists-view

6921cee

display flyout - not working right now, WIP

a244e83

properly formatted exceptions cards

38c2713

display title of exception list in blue color

9679dc3

cleanup

9c1245e

cleanup + start usage of pagination hooks

833ff73

working on pagination, sort of working

b3e7d29

working pagination, finally

7d0cca9

adds comment explaining bug in pagination, also reset default paginat…

47d95b1

…ion perPage property to 20

undo changes to getNewExceptionItem function

1a2d1b5

undo changes that made ruleName an optional parameter for ExceptionBu…

ae09187

…ilderProps

add ternary logic for pageCount in pagination of exception list cards

c69f21b

Merge remote-tracking branch 'upstream/main' into interim-exceptions-…

002850a

…all-lists

update snapshots, fix test mocks to include new properties, update te…

bdf8045

…st to match outcome where we are overwriting a list on import and the list item ids already exist so there should be no error when overwriting

try to fix cypress, I think I fixed all the jests tests though

a8dfd88

fixes jest test expected text in breadcrumbs

6d87807

fixes cypress tests

0cc8118

Merge remote-tracking branch 'upstream/main' into interim-exceptions-…

8139f2d

…all-lists

refactors cypress tests

316d952

move import flyout to separate file

9206a37

fix alignItems in the exception list card

c7add87

more i18n updates

48c2ade

dhurley14 marked this pull request as ready for review November 7, 2022 17:04

dhurley14 requested review from a team as code owners November 7, 2022 17:04

WafaaNasr reviewed Nov 7, 2022

View reviewed changes

...ugins/security_solution/public/exceptions/manage_exceptions/create_shared_exception_list.tsx Outdated Show resolved Hide resolved

WafaaNasr reviewed Nov 7, 2022

View reviewed changes

...ugins/security_solution/public/exceptions/manage_exceptions/create_shared_exception_list.tsx Outdated Show resolved Hide resolved

WafaaNasr reviewed Nov 7, 2022

View reviewed changes

...ugins/security_solution/public/exceptions/manage_exceptions/create_shared_exception_list.tsx Outdated Show resolved Hide resolved

WafaaNasr reviewed Nov 7, 2022

View reviewed changes

x-pack/plugins/security_solution/public/exceptions/manage_exceptions/use_create_shared_list.tsx Outdated Show resolved Hide resolved

WafaaNasr approved these changes Nov 7, 2022

View reviewed changes

dhurley14 self-assigned this Nov 7, 2022

dhurley14 added review Feature:Rule Exceptions Security Solution Detection Rule Exceptions area Team:Security Solution Platform Security Solution Platform Team v8.6.0 release_note:enhancement labels Nov 7, 2022

dhurley14 added 6 commits November 7, 2022 13:24

Merge branch 'main' into more-exceptions-work

2b24a88

fixes misspelling of function

2396070

adds constant for api route for creating a shared exception list, upd…

f5f3ec3

…ates code to use a form object and use only one onchange fn

Merge branch 'main' into more-exceptions-work

ba31ece

remove the commented out code

2f2579d

Merge branch 'more-exceptions-work' of github.com:dhurley14/kibana in…

1f44dc8

…to more-exceptions-work

YulNaumenko approved these changes Nov 9, 2022

View reviewed changes

dhurley14 merged commit b1179e7 into elastic:main Nov 9, 2022

dhurley14 deleted the more-exceptions-work branch November 9, 2022 14:54

kibanamachine added the backport:skip This commit does not require backporting label Nov 9, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution] [Exceptions] Adds options to create a shared exception list and to create a single item from the manage exceptions view #144575

[Security Solution] [Exceptions] Adds options to create a shared exception list and to create a single item from the manage exceptions view #144575

dhurley14 commented Nov 3, 2022 •

edited

Loading

WafaaNasr Nov 7, 2022

WafaaNasr left a comment

kibana-ci commented Nov 8, 2022

ESLint disabled in files

ESLint disabled line counts

Total ESLint disabled count

YulNaumenko left a comment

[Security Solution] [Exceptions] Adds options to create a shared exception list and to create a single item from the manage exceptions view #144575

[Security Solution] [Exceptions] Adds options to create a shared exception list and to create a single item from the manage exceptions view #144575

Conversation

dhurley14 commented Nov 3, 2022 • edited Loading

Summary

Checklist

WafaaNasr Nov 7, 2022

Choose a reason for hiding this comment

WafaaNasr left a comment

Choose a reason for hiding this comment

kibana-ci commented Nov 8, 2022

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Module Count

Async chunks

Page load bundle

ESLint disabled in files

ESLint disabled line counts

Total ESLint disabled count

History

YulNaumenko left a comment

Choose a reason for hiding this comment

dhurley14 commented Nov 3, 2022 •

edited

Loading