Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] add ungroup layers action #144574

Merged
merged 4 commits into from
Nov 7, 2022
Merged

[Maps] add ungroup layers action #144574

merged 4 commits into from
Nov 7, 2022

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Nov 3, 2022

follow up to #142528

PR adds "Ungroup layers" to layer groups action menu, allowing users a quick option to remove layer group and keep layers in it.

Screen Shot 2022-11-03 at 4 36 38 PM

@nreese
Copy link
Contributor Author

nreese commented Nov 7, 2022

@elasticmachine merge upstream

@nreese nreese added release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas backport:skip This commit does not require backporting v8.6.0 labels Nov 7, 2022
@nreese nreese marked this pull request as ready for review November 7, 2022 14:30
@nreese nreese requested a review from a team as a code owner November 7, 2022 14:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.7MB 2.7MB +450.0B
Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 58 64 +6
osquery 108 113 +5
securitySolution 440 446 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 66 72 +6
osquery 109 115 +6
securitySolution 517 523 +6
total +20

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@nickpeihl nickpeihl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

code review and tested in chrome

@nreese nreese merged commit adfa8f7 into elastic:main Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:fix Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants