-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Actionable Observability] Move the alerts search bar to triggers action UI plugin #144541
[Actionable Observability] Move the alerts search bar to triggers action UI plugin #144541
Conversation
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still working locally, LGTM :)
Does TriggersActionsUI plugin contain all the alerts/rules related components?
The TriggersActionsUI plugin contains the alerts/rules related components shared between different solutions such as Observability, Security, Stack management, ... But if we want to add an extra filter or functionality for alerts within observability (that we don't want to share with other solutions), we can put it in the observability plugin and share it with the apps within it (such as APM) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
noice!
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
async chunk count
ESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Resolves #144393
Summary
In this PR, I just move the alerts search bar component from the observability plugin to the triggers action UI. There should not be any change functionality-wise.
How to test