Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Actionable Observability] Move the alerts search bar to triggers action UI plugin #144541

Merged

Conversation

maryam-saeidi
Copy link
Member

Resolves #144393

Summary

In this PR, I just move the alerts search bar component from the observability plugin to the triggers action UI. There should not be any change functionality-wise.

How to test

  • Go to the alerts page in observability
  • Make sure that the alerts search bar works as before

@maryam-saeidi maryam-saeidi added chore release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" labels Nov 3, 2022
@maryam-saeidi maryam-saeidi marked this pull request as ready for review November 4, 2022 15:39
@maryam-saeidi maryam-saeidi requested review from a team as code owners November 4, 2022 15:39
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@maryam-saeidi maryam-saeidi changed the title [Actionable Observability] Move the alerts search bar to triggers action UI package [Actionable Observability] Move the alerts search bar to triggers action UI plugin Nov 4, 2022
Copy link
Contributor

@kdelemme kdelemme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still working locally, LGTM :)

Does TriggersActionsUI plugin contain all the alerts/rules related components?

@maryam-saeidi
Copy link
Member Author

Does TriggersActionsUI plugin contain all the alerts/rules related components?

The TriggersActionsUI plugin contains the alerts/rules related components shared between different solutions such as Observability, Security, Stack management, ...

But if we want to add an extra filter or functionality for alerts within observability (that we don't want to share with other solutions), we can put it in the observability plugin and share it with the apps within it (such as APM)

Copy link
Contributor

@jcger jcger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice!

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
observability 428 422 -6
triggersActionsUi 448 456 +8
total +2

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
observability 555 554 -1
triggersActionsUi 489 491 +2
total +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observability 495.0KB 490.6KB -4.4KB
triggersActionsUi 652.8KB 660.0KB +7.2KB
total +2.8KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
triggersActionsUi 49 50 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
triggersActionsUi 101.0KB 101.2KB +229.0B
Unknown metric groups

API count

id before after diff
observability 558 557 -1
triggersActionsUi 518 520 +2
total +1

async chunk count

id before after diff
triggersActionsUi 50 53 +3

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 58 64 +6
osquery 108 113 +5
securitySolution 440 446 +6
triggersActionsUi 131 132 +1
total +20

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 66 72 +6
osquery 109 115 +6
securitySolution 517 523 +6
triggersActionsUi 134 135 +1
total +21

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@maryam-saeidi maryam-saeidi merged commit 4d46bd7 into elastic:main Nov 7, 2022
@kibanamachine kibanamachine added v8.6.0 backport:skip This commit does not require backporting labels Nov 7, 2022
@maryam-saeidi maryam-saeidi deleted the 144393-move-alert-search-bar branch November 7, 2022 09:30
@maryam-saeidi maryam-saeidi self-assigned this Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting chore release_note:skip Skip the PR/issue when compiling release notes Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Actionable Observability] Move Shareable Alert Search Bar to trigger actions ui plugin
6 participants