[Fleet] parse elasticsearch.source_mode from manifest + small refactor
#144464
Conversation
hop-dev
added
release_note:skip
|
Pinging @elastic/fleet (Team:Fleet) |
| parsedElasticsearchEntry.privileges = elasticsearch.privileges; | ||
| } | ||
|
|
||
| if (elasticsearch?.source_mode) { |
There was a problem hiding this comment.
Source mode can only be one of two values, not sure if we should be validating here? We only seem to do high level validation
| @@ -351,6 +351,7 @@ export interface RegistryElasticsearch { | |||
| 'index_template.settings'?: estypes.IndicesIndexSettings; | |||
| 'index_template.mappings'?: estypes.MappingTypeMapping; | |||
| 'ingest_pipeline.name'?: string; | |||
There was a problem hiding this comment.
I am curious about the usage of this key, it looks like to me that is not used anywhere
There was a problem hiding this comment.
@nchaulet do you mean ingest_pipeline.name? It was added as part of this PR to make our logic the same as registry info:
https://github.com/elastic/kibana/pull/126915/files
It was added to the registry 2 years ago here elastic/package-registry#564 , I am not sure it was ever implemented in Kibana (until we implemented it in the above PR to make sure we match the registry) but I am nervous to delete it :D Should I just go for it?
There was a problem hiding this comment.
@nchaulet turns out the system package uses this functionality
hop-dev
force-pushed
the
support-source_mode
branch
from
a59d59c to
c0c6c7a
Compare
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Unknown metric groupsAPI count
ESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @hop-dev |
Summary
Part of #141211.
Add
source_modeto the elasticsearch fields we parse out of the package manifest. I noticed an opportunity to break out some small unit tests while I was in the code as well.