Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default refresh interval to 60 seconds #144389

Merged
merged 7 commits into from
Dec 1, 2022
Merged

Change default refresh interval to 60 seconds #144389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
42e2130
Disabling auto refresh by default
sorenlouv Nov 2, 2022
1ad5b1b
Fix discover tests
sorenlouv Nov 3, 2022
e87cf2d
Change refresh interval to 30000
sorenlouv Nov 4, 2022
c9f4313
Change refresh interval to 30s in tests
sorenlouv Nov 4, 2022
4e9b049
Update ui_settings.ts
sorenlouv Nov 23, 2022
c1e257a
Update _shared_links.ts
sorenlouv Nov 23, 2022
0579e80
Retain ML job list auto refresh behavior
pheyos Nov 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/plugins/data/server/ui_settings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,8 +324,8 @@ export function getUiSettings(
defaultMessage: 'Time filter refresh interval',
}),
value: `{
"pause": false,
"value": 0
"pause": true,
"value": 60000
}`,
type: 'json',
description: i18n.translate('data.advancedSettings.timepicker.refreshIntervalDefaultsText', {
Expand Down
4 changes: 2 additions & 2 deletions test/functional/apps/discover/group1/_shared_links.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
const expectedUrl =
baseUrl +
'/app/discover?_t=1453775307251#' +
'/?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time' +
'/?_g=(filters:!(),refreshInterval:(pause:!t,value:60000),time' +
":(from:'2015-09-19T06:31:44.000Z',to:'2015-09" +
"-23T18:31:44.000Z'))&_a=(columns:!(),filters:!(),index:'logstash-" +
"*',interval:auto,query:(language:kuery,query:'')" +
Expand All @@ -102,7 +102,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
baseUrl +
'/app/discover#' +
'/view/ab12e3c0-f231-11e6-9486-733b1ac9221a' +
'?_g=(filters%3A!()%2CrefreshInterval%3A(pause%3A!t%2Cvalue%3A0)' +
'?_g=(filters%3A!()%2CrefreshInterval%3A(pause%3A!t%2Cvalue%3A60000)' +
"%2Ctime%3A(from%3A'2015-09-19T06%3A31%3A44.000Z'%2C" +
"to%3A'2015-09-23T18%3A31%3A44.000Z'))";
await PageObjects.discover.loadSavedSearch('A Saved Search');
Expand Down
4 changes: 2 additions & 2 deletions ...me_analytics/pages/analytics_management/components/analytics_list/use_refresh_interval.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ export const useRefreshInterval = (

function initAutoRefresh() {
const interval = globalState?.refreshInterval ?? timefilter.getRefreshInterval();
const { value } = interval;
const { pause, value } = interval;

if (value === 0) {
if (pause === true || value === 0) {
// the auto refresher starts in an off state
// so switch it on and set the interval to 30s
timefilter.setRefreshInterval({
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugins/ml/public/application/routing/routes/jobs_list.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ const PageWrapper: FC<PageProps> = ({ deps }) => {

useEffect(() => {
const refreshInterval =
refreshValue === 0 && refreshPause === true
refreshValue === 0 || refreshPause === true
? { pause: false, value: DEFAULT_REFRESH_INTERVAL_MS }
: { pause: refreshPause, value: refreshValue };
timefilter.setRefreshInterval(refreshInterval);
Expand Down