Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump field limit for esArchiver indices using #144272

Merged
merged 2 commits into from
Nov 1, 2022
Merged

Conversation

rudolf
Copy link
Contributor

@rudolf rudolf commented Oct 31, 2022

Summary

In #138377 (comment) I fixed the field limit of most esArchives but somehow missed one. This PR updates the field limit to the last esArchive that uses the .kibana_$KIBANA_PACKAGE_VERSION_001 template variable to pretend to Kibana that this index already has a migration applied. When this happens migrations won't create a new index so it never sets the field limit to 1500 instead of the default of 1000.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@rudolf rudolf added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:Migrations release_note:skip Skip the PR/issue when compiling release notes labels Oct 31, 2022
@rudolf rudolf marked this pull request as ready for review October 31, 2022 19:33
@rudolf rudolf enabled auto-merge (squash) October 31, 2022 19:35
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 57 63 +6
osquery 103 108 +5
securitySolution 439 443 +4
total +17

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 65 71 +6
osquery 104 110 +6
securitySolution 516 520 +4
total +18

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jloleysens jloleysens mentioned this pull request Nov 1, 2022
1 task
@rudolf rudolf merged commit e476028 into main Nov 1, 2022
@rudolf rudolf deleted the es-esarchiver-field-limit branch November 1, 2022 21:00
@kibanamachine kibanamachine added v8.6.0 backport:skip This commit does not require backporting labels Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting Feature:Migrations release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants