[Discover] Track adhoc data views usage #144244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimaanj
added
Feature:Discover
|
Pinging @elastic/kibana-data-discovery (Team:DataDiscovery) |
jughosta
reviewed
Nov 2, 2022
| trackUiMetric(METRIC_TYPE.CLICK, ADHOC_DATA_VIEW_CLICK_EVENT, adHocDataViewList.length); | ||
| } | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, [adHocDataViewList]); |
There was a problem hiding this comment.
I guess we should send an event only if current data view on Discover is ad-hoc, not for the available list of them. On Lens page it's a bit different: several data views can be active and referenced in vis layers.
jughosta
reviewed
Nov 2, 2022
|
@elasticmachine merge upstream |
|
merge conflict between base and head |
…dhoc-usage # Conflicts: # src/plugins/discover/public/application/main/hooks/use_discover_state.ts
|
@elasticmachine merge upstream |
jughosta
reviewed
Nov 15, 2022
src/plugins/discover/public/application/main/hooks/use_adhoc_data_views.ts
Outdated
Show resolved
Hide resolved
jughosta
approved these changes
Nov 17, 2022
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: cc @dimaanj |
dimaanj
added
v8.7.0
auto-backport
kibanamachine
pushed a commit
that referenced
this pull request
Nov 17, 2022
## Summary Closes #141090 This PR enabled metrics for adhoc data views usage in Discover. Co-authored-by: Julia Rechkunova <[email protected]> (cherry picked from commit 2454fd0)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
kibanamachine
added a commit
that referenced
this pull request
Nov 17, 2022
# Backport This will backport the following commits from `main` to `8.6`: - [[Discover] Track adhoc data views usage (#144244)](#144244) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dmitry Tomashevich","email":"[email protected]"},"sourceCommit":{"committedDate":"2022-11-17T11:29:35Z","message":"[Discover] Track adhoc data views usage (#144244)\n\n## Summary\r\n\r\nCloses #141090\r\n\r\nThis PR enabled metrics for adhoc data views usage in Discover.\r\n\r\nCo-authored-by: Julia Rechkunova <[email protected]>","sha":"2454fd01b08767b31f25fe4674ac92b9633606f6","branchLabelMapping":{"^v8.7.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Discover","release_note:skip","auto-backport","Team:DataDiscovery","v8.6.0","v8.7.0"],"number":144244,"url":"https://github.com/elastic/kibana/pull/144244","mergeCommit":{"message":"[Discover] Track adhoc data views usage (#144244)\n\n## Summary\r\n\r\nCloses #141090\r\n\r\nThis PR enabled metrics for adhoc data views usage in Discover.\r\n\r\nCo-authored-by: Julia Rechkunova <[email protected]>","sha":"2454fd01b08767b31f25fe4674ac92b9633606f6"}},"sourceBranch":"main","suggestedTargetBranches":["8.6"],"targetPullRequestStates":[{"branch":"8.6","label":"v8.6.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.7.0","labelRegex":"^v8.7.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/144244","number":144244,"mergeCommit":{"message":"[Discover] Track adhoc data views usage (#144244)\n\n## Summary\r\n\r\nCloses #141090\r\n\r\nThis PR enabled metrics for adhoc data views usage in Discover.\r\n\r\nCo-authored-by: Julia Rechkunova <[email protected]>","sha":"2454fd01b08767b31f25fe4674ac92b9633606f6"}}]}] BACKPORT--> Co-authored-by: Dmitry Tomashevich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #141090
This PR enabled metrics for adhoc data views usage in Discover.