Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alert Summaries] [BE] Move “Notify When” and throttle from rule to action #144130

Merged
merged 33 commits into from
Nov 16, 2022
Merged
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
52d3433
Add frequency props to actions and validate them on edit/create
Zacqary Oct 27, 2022
d077ea1
Nullify undefined throttle
Zacqary Oct 27, 2022
378d4e8
Update schema to allow for frequency param on actions
Zacqary Oct 27, 2022
11cd1d3
[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…
kibanamachine Oct 27, 2022
4889023
Commit missing file
Zacqary Oct 28, 2022
1a84f27
Merge remote-tracking branch 'upstream/main' into 143368-notify-migra…
Zacqary Oct 28, 2022
4349c73
Fix types
Zacqary Oct 28, 2022
1c869ab
Merge branch '143368-notify-migration' of https://github.com/Zacqary/…
Zacqary Oct 28, 2022
ef43549
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine Oct 28, 2022
cb3f976
Fix types
Zacqary Oct 31, 2022
77711c2
Fix jest
Zacqary Oct 31, 2022
3d23b1c
Merge branch '143368-notify-migration' of https://github.com/Zacqary/…
Zacqary Oct 31, 2022
2abc7ae
Fix validating global freq params
Zacqary Oct 31, 2022
66810ae
Add tests for create and edit
Zacqary Oct 31, 2022
adf815f
Merge remote-tracking branch 'upstream/main' into 143368-notify-migra…
Zacqary Nov 1, 2022
20d4983
Reset legacy api
Zacqary Nov 2, 2022
24fe88c
Make notify and throttle optional in route schemas
Zacqary Nov 2, 2022
b35150b
Merge remote-tracking branch 'upstream/main' into 143368-notify-migra…
Zacqary Nov 3, 2022
bed44bc
Fix tests
Zacqary Nov 3, 2022
3b12f0f
Split missing frequency test cases
Zacqary Nov 4, 2022
b2bebdf
Handle xor undefined global frequency params
Zacqary Nov 7, 2022
e6b1843
Merge remote-tracking branch 'upstream/main' into 143368-notify-migra…
Zacqary Nov 7, 2022
11e16a5
Fix typecheck
Zacqary Nov 7, 2022
dec2b1a
Merge remote-tracking branch 'upstream/main' into 143368-notify-migra…
Zacqary Nov 8, 2022
bed5753
Refactor global freq param validation and clarify error messages
Zacqary Nov 9, 2022
26df5b5
Update jest snapshots
Zacqary Nov 9, 2022
cda3467
Merge remote-tracking branch 'upstream/main' into 143368-notify-migra…
Zacqary Nov 15, 2022
023cb65
Fix bad merge
Zacqary Nov 15, 2022
7a517e0
Merge remote-tracking branch 'upstream/main' into 143368-notify-migra…
Zacqary Nov 15, 2022
36d0843
Remove extraneous file
Zacqary Nov 15, 2022
da42cd2
Merge remote-tracking branch 'upstream/main' into 143368-notify-migra…
Zacqary Nov 16, 2022
4287aeb
Merge branch 'main' into 143368-notify-migration
kibanamachine Nov 16, 2022
4cf5498
Merge branch 'main' into 143368-notify-migration
kibanamachine Nov 16, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix tests
Zacqary committed Nov 3, 2022
commit bed44bcd4497ef4c998d1a50db773fbd14f3fc09
2 changes: 1 addition & 1 deletion x-pack/plugins/alerting/server/routes/create_rule.ts
Original file line number Diff line number Diff line change
@@ -32,7 +32,7 @@ export const bodySchema = schema.object({
enabled: schema.boolean({ defaultValue: true }),
consumer: schema.string(),
tags: schema.arrayOf(schema.string(), { defaultValue: [] }),
throttle: schema.maybe(schema.nullable(schema.string({ validate: validateDurationSchema }))),
throttle: schema.nullable(schema.maybe(schema.string({ validate: validateDurationSchema }))),
params: schema.recordOf(schema.string(), schema.any(), { defaultValue: {} }),
schedule: schema.object({
interval: schema.string({ validate: validateDurationSchema }),
2 changes: 1 addition & 1 deletion x-pack/plugins/alerting/server/routes/update_rule.ts
Original file line number Diff line number Diff line change
@@ -36,7 +36,7 @@ const bodySchema = schema.object({
schedule: schema.object({
interval: schema.string({ validate: validateDurationSchema }),
}),
throttle: schema.maybe(schema.nullable(schema.string({ validate: validateDurationSchema }))),
throttle: schema.nullable(schema.maybe(schema.string({ validate: validateDurationSchema }))),
params: schema.recordOf(schema.string(), schema.any(), { defaultValue: {} }),
actions: actionsSchema,
notify_when: schema.maybe(schema.string({ validate: validateNotifyWhenType })),