Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Data Frame Analytics: Fixes results page saved object sync warning. #144109

Merged
merged 1 commit into from
Oct 27, 2022
Merged

[ML] Data Frame Analytics: Fixes results page saved object sync warning. #144109

merged 1 commit into from
Oct 27, 2022

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Oct 27, 2022 •
edited
Loading

Summary

Fixes #144106.

  • Fixes the saved object sync warning that should be shown on the analytics result pages.
  • Adds a check if the jobs description is an empty string to avoid unnecessary whitespace rendering.

image

Checklist

@walterra walterra added bug Fixes for quality problems that affect the customer experience :ml Feature:Data Frame Analytics ML data frame analytics features v8.6.0 v8.5.1 labels Oct 27, 2022
@walterra walterra requested a review from a team as a code owner October 27, 2022 14:34
@walterra walterra self-assigned this Oct 27, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@walterra walterra force-pushed the ml-fix-dfa-results-saved-object-sync-warning branch from 936a20e to 3da2b29 Compare October 27, 2022 14:38
@walterra walterra added release_note:skip Skip the PR/issue when compiling release notes backport pending backport:skip This commit does not require backporting labels Oct 27, 2022
jgowdyelastic
jgowdyelastic approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.4MB 3.4MB +267.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @walterra

@qn895
Copy link
Member

qn895 commented Oct 27, 2022

LGTM 🎉

@walterra walterra merged commit a602fa8 into elastic:main Oct 27, 2022
@walterra walterra deleted the ml-fix-dfa-results-saved-object-sync-warning branch October 27, 2022 16:01
jloleysens added a commit to jloleysens/kibana that referenced this pull request Oct 27, 2022
@jloleysens
Merge branch 'main' into files-move-to-src
1b2d913 
* main: (24 commits)
  [Files] Add file upload to file picker (elastic#143969)
  [Security solution] Guided onboarding, alerts & cases (elastic#143598)
  [APM] Critical path for a single trace (elastic#143735)
  skip failing test suite (elastic#143933)
  [Fleet] Update GH Projects automation (elastic#144123)
  [APM] Performance fix for 'cardinality' telemetry task (elastic#144061)
  [Enterprise Search] Attach ML Inference Pipeline - Pipeline re-use (elastic#143979)
  [8.5][DOCS] Add support for differential logs (elastic#143242)
  Bump nwsapi from v2.2.0 to v2.2.2 (elastic#144001)
  [APM] Add waterfall to dependency operations (elastic#143257)
  [Shared UX] Add deprecation message to kibana react Markdown (elastic#143766)
  [Security Solution][Endpoint] Adds RBAC API checks for Blocklist (elastic#144047)
  Improve `needs-team` auto labeling regex (elastic#143787)
  [Reporting/CSV Export] _id field can not be formatted (elastic#143807)
  Adds SavedObjectsWarning to analytics results pages. (elastic#144109)
  Bump chromedriver to 107 (elastic#144073)
  Update cypress (elastic#143755)
  [Maps] nest security layers in layer group (elastic#144055)
  [Lens][Agg based Heatmap] Navigate to Lens Agg based Heatmap. (elastic#143820)
  Added support of saved search (elastic#144095)
  ...
@walterra walterra removed the backport:skip This commit does not require backporting label Nov 2, 2022
walterra added a commit to walterra/kibana that referenced this pull request Nov 2, 2022
@walterra
Adds SavedObjectsWarning to analytics results pages. (elastic#144109)
4110cd3 
- Fixes the saved object sync warning that should be shown on the analytics result pages.
- Adds a check if the jobs description is an empty string to avoid unnecessary whitespace rendering.

(cherry picked from commit a602fa8)
@walterra walterra mentioned this pull request Nov 2, 2022
Merged
@walterra
Copy link
Contributor Author

walterra commented Nov 2, 2022

💚 All backports created successfully

Status Branch Result
✅ 8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

walterra added a commit that referenced this pull request Nov 2, 2022
@walterra
Adds SavedObjectsWarning to analytics results pages. (#144109) (#144401)
42f85ad 
- Fixes the saved object sync warning that should be shown on the analytics result pages.
- Adds a check if the jobs description is an empty string to avoid unnecessary whitespace rendering.

(cherry picked from commit a602fa8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qn895 qn895 qn895 approved these changes

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

Assignees

@walterra walterra

Labels
bug Fixes for quality problems that affect the customer experience Feature:Data Frame Analytics ML data frame analytics features :ml release_note:skip Skip the PR/issue when compiling release notes v8.5.1 v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] Data frame analytics: Saved object not created for model's space awareness.
5 participants
@walterra @elasticmachine @kibana-ci @qn895 @jgowdyelastic