[Security Solution][Endpoint][Response Actions] Show download link for `get-file` action on response actions history #144094

ashokaditya · 2022-10-27T12:10:06Z

Summary

Shows a download link for get-file action on success for users with file operation permission/privilege (RBAC). The link is not shown when the user doesn't have that permission.

To verify. Create a role without file operations and log in with a user that has only this custom role assigned. You should not see the download link on successful get-file actions.

with file operation permission

without file operation permission

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
This was checked for cross-browser compatibility

Show download link for successful get-file actions on action history fixes elastic/security-team/issues/5076

elasticmachine · 2022-10-27T12:14:44Z

Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt)

fixes elastic/security-team/issues/5076

paul-tavares · 2022-10-27T13:48:23Z

...ublic/management/components/endpoint_responder/endpoint_response_actions_console_commands.ts

@@ -379,7 +379,7 @@ export const getEndpointResponseActionsConsoleCommands = ({
        capabilities: endpointCapabilities,
        privileges: endpointPrivileges,
      },
-      exampleUsage: 'get-file path "/full/path/to/file.txt" --comment "Possible malware"',
+      exampleUsage: 'get-file --path "/full/path/to/file.txt" --comment "Possible malware"',


Thank you 🙏

...on/public/management/components/endpoint_response_actions_list/response_actions_log.test.tsx

paul-tavares · 2022-10-27T13:56:00Z

...agement/components/response_action_file_download_link/response_action_file_download_link.tsx

-          />
-        </EuiText>
-      </>
+      <EuiFlexGroup alignItems="center" gutterSize="none">


can you add data-test-subj={dataTestSubj} here so that the entire component gets a test subject?

…ry-5076

@paul-tavares

review changes (@paul-tavares)

@paul-tavares

review change (@paul-tavares)

dasansol92

Looking good! Left a comment, let me know what do you think about it!

...blic/management/components/endpoint_response_actions_list/use_response_actions_log_table.tsx

@dasansol92

review change (@dasansol92)

dasansol92

Thanks for the changes! LGTM!

gergoabraham

only one small suggestion, looks great 🎉

...blic/management/components/endpoint_response_actions_list/use_response_actions_log_table.tsx

…ry-5076

@gergoabraham

review suggestion (@gergoabraham)

kibana-ci · 2022-10-31T10:05:08Z

💚 Build Succeeded

Buildkite Build
Commit: 39e25d7

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	9.6MB	9.6MB	+463.0B

Unknown metric groups

ESLint disabled in files

id	before	after	diff
`osquery`	1	2	+1

ESLint disabled line counts

id	before	after	diff
`enterpriseSearch`	19	21	+2
`fleet`	57	63	+6
`osquery`	103	108	+5
`securitySolution`	439	443	+4
total			+17

Total ESLint disabled count

id	before	after	diff
`enterpriseSearch`	20	22	+2
`fleet`	65	71	+6
`osquery`	104	110	+6
`securitySolution`	516	520	+4
total			+18

History

💛 Build #83550 was flaky be87496
💚 Build #83461 succeeded e67bf36
💔 Build #83438 failed cda69c7
💔 Build #83153 failed 7660a16

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ashokaditya

ashokaditya added 2 commits October 27, 2022 12:45

Show download link for get-file success

c8002eb

Show download link for successful get-file actions on action history fixes elastic/security-team/issues/5076

add missing help prefix

f5289a5

ashokaditya self-assigned this Oct 27, 2022

ashokaditya added v8.6.0 release_note:skip Skip the PR/issue when compiling release notes Team:Defend Workflows “EDR Workflows” sub-team of Security Solution OLM Sprint labels Oct 27, 2022

ashokaditya marked this pull request as ready for review October 27, 2022 12:14

ashokaditya requested a review from a team as a code owner October 27, 2022 12:14

ashokaditya requested review from gergoabraham and paul-tavares October 27, 2022 12:14

add tests

7660a16

fixes elastic/security-team/issues/5076

paul-tavares reviewed Oct 27, 2022

View reviewed changes

ashokaditya and others added 2 commits October 28, 2022 09:13

Merge branch 'main' into feat/olm-get-file-download-link-action-histo…

cda69c7

…ry-5076

update tests

72aed7e

review changes (@paul-tavares)

ashokaditya force-pushed the feat/olm-get-file-download-link-action-history-5076 branch from f926f7c to 72aed7e Compare October 28, 2022 08:52

ashokaditya requested a review from paul-tavares October 28, 2022 09:11

use test ids instead

e67bf36

review change (@paul-tavares)

ashokaditya force-pushed the feat/olm-get-file-download-link-action-history-5076 branch from b85bc15 to e67bf36 Compare October 28, 2022 09:25

dasansol92 reviewed Oct 28, 2022

View reviewed changes

...blic/management/components/endpoint_response_actions_list/use_response_actions_log_table.tsx Outdated Show resolved Hide resolved

Update use_response_actions_log_table.tsx

be87496

review change (@dasansol92)

ashokaditya requested a review from dasansol92 October 28, 2022 14:06

dasansol92 approved these changes Oct 28, 2022

View reviewed changes

gergoabraham approved these changes Oct 28, 2022

View reviewed changes

...blic/management/components/endpoint_response_actions_list/use_response_actions_log_table.tsx Outdated Show resolved Hide resolved

ashokaditya and others added 2 commits October 31, 2022 09:35

Merge branch 'main' into feat/olm-get-file-download-link-action-histo…

a50e4a0

…ry-5076

reorder if statements

39e25d7

review suggestion (@gergoabraham)

ashokaditya enabled auto-merge (squash) October 31, 2022 08:53

ashokaditya merged commit 43ffa96 into elastic:main Oct 31, 2022

kibanamachine added the backport:skip This commit does not require backporting label Oct 31, 2022

ashokaditya deleted the feat/olm-get-file-download-link-action-history-5076 branch October 31, 2022 10:31

ashokaditya added release_note:feature Makes this part of the condensed release notes and removed release_note:skip Skip the PR/issue when compiling release notes labels Oct 31, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution][Endpoint][Response Actions] Show download link for `get-file` action on response actions history #144094

[Security Solution][Endpoint][Response Actions] Show download link for `get-file` action on response actions history #144094

ashokaditya commented Oct 27, 2022 •

edited

Loading

elasticmachine commented Oct 27, 2022

paul-tavares Oct 27, 2022

paul-tavares Oct 27, 2022

ashokaditya Oct 28, 2022

dasansol92 left a comment

dasansol92 left a comment

gergoabraham left a comment

kibana-ci commented Oct 31, 2022

ESLint disabled in files

ESLint disabled line counts

Total ESLint disabled count

[Security Solution][Endpoint][Response Actions] Show download link for get-file action on response actions history #144094

[Security Solution][Endpoint][Response Actions] Show download link for get-file action on response actions history #144094

Conversation

ashokaditya commented Oct 27, 2022 • edited Loading

Summary

Checklist

elasticmachine commented Oct 27, 2022

paul-tavares Oct 27, 2022

Choose a reason for hiding this comment

paul-tavares Oct 27, 2022

Choose a reason for hiding this comment

ashokaditya Oct 28, 2022

Choose a reason for hiding this comment

dasansol92 left a comment

Choose a reason for hiding this comment

dasansol92 left a comment

Choose a reason for hiding this comment

gergoabraham left a comment

Choose a reason for hiding this comment

kibana-ci commented Oct 31, 2022

💚 Build Succeeded

Metrics [docs]

Async chunks

ESLint disabled in files

ESLint disabled line counts

Total ESLint disabled count

History

[Security Solution][Endpoint][Response Actions] Show download link for `get-file` action on response actions history #144094

[Security Solution][Endpoint][Response Actions] Show download link for `get-file` action on response actions history #144094

ashokaditya commented Oct 27, 2022 •

edited

Loading