Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Files] Fix image loading state #143970

Merged
merged 3 commits into from
Oct 28, 2022

Conversation

jloleysens
Copy link
Contributor

@jloleysens jloleysens commented Oct 25, 2022

Summary

A small regression for image loading state causes a state where both the blur and the image can be visible at the same time. This is only visible on super slow network.

Regression from #143843

Screenshot 2022-10-25 at 18 14 57

@jloleysens jloleysens added release_note:skip Skip the PR/issue when compiling release notes auto-backport Deprecated - use backport:version if exact versions are needed Team:AppServicesUx feature:Files v8.6.0 labels Oct 25, 2022
@jloleysens jloleysens requested a review from a team as a code owner October 25, 2022 16:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesUx)

@jloleysens jloleysens enabled auto-merge (squash) October 27, 2022 20:54
@jloleysens
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
files 19.5KB 19.5KB +58.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jloleysens jloleysens merged commit a2cc569 into elastic:main Oct 28, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 28, 2022
@jloleysens jloleysens deleted the files-image-fix-loading-state branch October 31, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed backport:skip This commit does not require backporting feature:Files release_note:skip Skip the PR/issue when compiling release notes v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants