Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Guided onboarding] Address Kubernetes guide copy feedback #143968

Merged

Conversation

alisonelizabeth
Copy link
Contributor

Partially addresses #139741

This PR updates the copy for the Kubernetes guide.

Screenshots

Screen Shot 2022-10-25 at 11 52 46 AM

Screen Shot 2022-10-25 at 11 47 30 AM

Screen Shot 2022-10-25 at 11 47 59 AM

Screen Shot 2022-10-25 at 11 49 54 AM

Screen Shot 2022-10-25 at 11 51 14 AM

Screen Shot 2022-10-25 at 11 51 19 AM

Screen Shot 2022-10-25 at 11 51 24 AM

Screen Shot 2022-10-25 at 11 51 29 AM

Screen Shot 2022-10-25 at 11 51 35 AM

Screen Shot 2022-10-25 at 11 51 41 AM

@alisonelizabeth alisonelizabeth added release_note:skip Skip the PR/issue when compiling release notes ui-copy Review of UI copy with docs team is recommended Team:Journey/Onboarding Platform Journey Onboarding team labels Oct 25, 2022
}
),
description: i18n.translate(
'guidedOnboarding.observabilityGuide.viewDashboardStep.manualCompletionPopoverDescription',
{
defaultMessage: `Take your time to explore out-of-the-box dashboards that are included with the Kubernetes integration. When you're ready, you can access the next step of the guide in the button above.`,
defaultMessage: `Take your time to explore these pre-built dashboards included with the Kubernetes integration. When youre ready, click the Setup guide button to continue.`,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

click the Setup guide button to continue

@kellyemurphy I think your recommendation was to prompt the user to click a "Next" button. However, that is not supported in the current design. Let me know what you think.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha, it's ok as-is then.

@alisonelizabeth alisonelizabeth marked this pull request as ready for review October 25, 2022 16:02
@alisonelizabeth alisonelizabeth requested review from a team as code owners October 25, 2022 16:02
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-onboarding (Team:Journey/Onboarding)

@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Oct 25, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

Copy link
Contributor

@kellyemurphy kellyemurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy LGTM

Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fleet changes LGTM

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 916.8KB 916.8KB +1.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
guidedOnboarding 21.5KB 21.5KB -58.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@yuliacech yuliacech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM @alisonelizabeth 👍

@alisonelizabeth alisonelizabeth merged commit 0bdd981 into elastic:main Oct 26, 2022
@alisonelizabeth alisonelizabeth deleted the guided_onboarding/observ_copy branch October 26, 2022 12:32
@kibanamachine kibanamachine added v8.6.0 backport:skip This commit does not require backporting labels Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team Team:Journey/Onboarding Platform Journey Onboarding team ui-copy Review of UI copy with docs team is recommended v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants