Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Multi metric partition charts #143966

Merged
merged 99 commits into from
Nov 14, 2022
Merged

[Lens] Multi metric partition charts #143966

merged 99 commits into from
Nov 14, 2022

Conversation

drewdaemon
Copy link
Contributor

@drewdaemon drewdaemon commented Oct 25, 2022 •
edited
Loading

Summary

Closes #8143

Screen.Recording.2022-11-16.at.3.21.33.PM.mov

Checklist

Delete any items that are not applicable to this PR.

drewdaemon and others added 30 commits September 1, 2022 12:44
@drewdaemon
partitionByColumn at the expression level
f07e24e
@drewdaemon
pie expression supports multiple metrics
53bbcb4
@drewdaemon
test metric collapsing
4920044
@drewdaemon
add defaulting to function signature
ced6a23
@drewdaemon
handle no bucket columns case
b4dab19
@drewdaemon
integrate multiple metrics at the lens vis level
3ec7089
@drewdaemon
collapseMetricColumns gets own module
b9e2a43
@drewdaemon
restore inspector
6c65fd2
@drewdaemon
add metric collapse to other partition types
90a7706
@drewdaemon
Merge branch 'main' of github.com:elastic/kibana into 8143/support-fi…
30309a7 
…eld-groups-in-partition-charts-same-interface-strategy
@drewdaemon
apply field formatting to bucket values during collapse
5a5b039
@drewdaemon
use already-provided format service
8b3e0ca
@drewdaemon
update tests
545d732
@drewdaemon
support consolidated tables for filtering
1ea78a6
@drewdaemon
update tests and names
bbf2a4f
@drewdaemon
update state generation code
eec55e6
@drewdaemon
test multi-metric filtering logic
da38b59
@drewdaemon
fix aggs-based
b0461d8
@drewdaemon
update pie_vis element expression
3818e21
@drewdaemon
Merge branch 'main' of github.com:elastic/kibana into 8143/support-fi…
493d8cf 
…eld-groups-in-partition-charts-same-interface-strategy
@drewdaemon
update snapshot
0c59453
@drewdaemon
suggestions
a41e035
@drewdaemon
one more suggestion test
eb3c77e
@drewdaemon
rename secondary group
4c3305b
@drewdaemon
handle case when column is not found
1c78548
@drewdaemon
remove unused translations
c6002d2
@drewdaemon
add migration
6147797
@drewdaemon
Merge branch 'main' of github.com:elastic/kibana into 8143/support-fi…
0304f96 
…eld-groups-in-partition-charts-same-interface-strategy
@kibanamachine
Merge branch 'main' into 8143/support-field-groups-in-partition-chart…
17069fd 
…s-same-interface-strategy
@drewdaemon
Merge branch 'main' of github.com:elastic/kibana into 8143/support-fi…
89b80e1 
…eld-groups-in-partition-charts-same-interface-strategy
Heenawter
Heenawter approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@Heenawter Heenawter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only - very small change to Canvas pie vis element because of renaming from metric to metrics. LGTM 👍

flash1293
flash1293 approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested around and everything works fine, LGTM

MichaelMarcialis
MichaelMarcialis approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@MichaelMarcialis MichaelMarcialis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on all of our discussions and planned phases. Thanks!

@drewdaemon
Copy link
Contributor Author

@elasticmachine merge upstream

@elastic elastic deleted a comment from kibana-ci Nov 10, 2022
@drewdaemon
Copy link
Contributor Author

@elasticmachine merge upstream

@drewdaemon
Copy link
Contributor Author

@elasticmachine merge upstream

mbondyra
mbondyra approved these changes Nov 14, 2022
View reviewed changes
Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i tested very briefly but looks awesome :)

@drewdaemon drewdaemon enabled auto-merge (squash) November 14, 2022 22:57
@drewdaemon drewdaemon merged commit e2d3bb9 into elastic:main Nov 14, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
expressionPartitionVis 100 102 +2
lens 886 888 +2
total +4

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
lens 587 590 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.1MB 3.1MB +3.0B
canvas 1.0MB 1.0MB +1.0B
expressionPartitionVis 51.0KB 52.2KB +1.3KB
lens 1.3MB 1.3MB +3.0KB
osquery 1019.2KB 1019.2KB +6.0B
ux 163.1KB 163.1KB +3.0B
total +4.2KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
lens 49 48 -1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
expressionPartitionVis 23.8KB 24.3KB +569.0B
visTypePie 12.2KB 12.2KB +31.0B
total +600.0B
Unknown metric groups

API count

id before after diff
lens 681 685 +4

ESLint disabled in files

id before after diff
osquery 1 2 +1

ESLint disabled line counts

id before after diff
enterpriseSearch 19 21 +2
fleet 59 65 +6
osquery 108 113 +5
securitySolution 441 447 +6
total +19

Total ESLint disabled count

id before after diff
enterpriseSearch 20 22 +2
fleet 67 73 +6
osquery 109 115 +6
securitySolution 518 524 +6
total +20

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine kibanamachine added v8.6.0 backport:skip This commit does not require backporting labels Nov 14, 2022
@drewdaemon drewdaemon mentioned this pull request Nov 15, 2022
Closed
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 15, 2022
@jloleysens
Merge branch 'main' into files-management
6c5fb8a 
* main: (65 commits)
  Migrate server-side `Root` and `Server` to packages (elastic#144990)
  [Discover] Handle no data views state for `esQuery` alert (elastic#145052)
  [ML] Allow updates for number of allocations and priority for trained model deployments (elastic#144704)
  [api-docs] 2022-11-15 Daily api_docs build (elastic#145203)
  [Security solution] remove guided onboarding feature flag (elastic#144247)
  [DOCS] Automate final case APIs (elastic#145007)
  [Enterprise Search] Name and description flyout for connectors (elastic#143827)
  [Guided onboarding] Update header button logic (elastic#144634)
  [Lens] Multi metric partition charts (elastic#143966)
  [Dashboard] [Controls] Add unmapped runtime field support to options list (elastic#144947)
  [Security Solution] Add Task Metric Collection to New Tasks (elastic#145181)
  [TriggersActionsUi] disable jest config in CI (elastic#145186)
  [TableListView] Enhance tag filtering (elastic#142108)
  [Cloud Posture] Compliance by CIS section table (elastic#145114)
  [8.6][Session View] Fix hidden alert flyout  in session view (elastic#145141)
  [customIntegrations] async load all components (elastic#145166)
  Fix time for logs smoke tests in integration test (elastic#145130)
  [RAM] Update rule status (elastic#140882)
  Update babel (main) (elastic#145060)
  [Actionable Observability] Add context.alertDetailsUrl variable to action connector template for APM rule types (elastic#144791)
  ...
@MichaelKatsoulis MichaelKatsoulis mentioned this pull request Nov 17, 2022
Merged
@MichaelKatsoulis MichaelKatsoulis mentioned this pull request Jun 15, 2023
Closed
@drewdaemon drewdaemon mentioned this pull request Sep 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dej611 dej611 dej611 left review comments

@tomsonpl tomsonpl tomsonpl approved these changes

@Heenawter Heenawter Heenawter approved these changes

@mbondyra mbondyra mbondyra approved these changes

@MichaelMarcialis MichaelMarcialis MichaelMarcialis approved these changes

@shahzad31 shahzad31 shahzad31 approved these changes

@flash1293 flash1293 flash1293 approved these changes

@dgieselaar dgieselaar dgieselaar approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Lens release_note:enhancement Team:APM All issues that need APM UI Team support Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability Team:Visualizations Visualization editors, elastic-charts and infrastructure ui-copy Review of UI copy with docs team is recommended v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pie chart as sum of multiple fields