-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Revisit Random sampling UI #143929
Conversation
Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, @dej611! Thanks for making these changes. I've opened up a quick PR in your repo containing all of my design suggestions. Please give that a look when you get a moment. Once approved and merged, I can approve this PR.
@MichaelMarcialis I wasn't sure of the |
I think in most cases, we should use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for merging in those changes. Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM code review only
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice new feature (just reviewing this and the previous merged PR to notice the change) 👌🏼
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
Talked offline with @KOTungseth : will merge this now and a PR with docs changes will follow up if required |
## Summary Updates the Random sampling copy. Original PR: #143929 Co-authored-by: Kibana Machine <[email protected]>
Summary
Follow up from #143221
Updated with @MichaelMarcialis feedback PR.
Changes summary:
EuiFormRow
fromcolumnCompressed
torowCompressed
to allow the slider to expand to the full available width of the flyout.Revisited UI design as discussed with @MichaelMarcialis .
Created a copy stub for the help text @KOTungseth
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers