Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor getHitCount, use Last_1 year #143912

Merged
merged 2 commits into from
Oct 25, 2022
Merged

refactor getHitCount, use Last_1 year #143912

merged 2 commits into from
Oct 25, 2022

Conversation

LeeDr
Copy link

@LeeDr LeeDr commented Oct 24, 2022

Summary

NOTE: The tests in this PR don't run as a part of the regular Kibana CI.

In x-pack/test/upgrade/apps/discover/discover_smoke_tests.ts I hit a failure after changing the time span of the test to Last_1 year because the hit count was a string including the comma-separator like "9,340" and that didn't compare greater than the int 0. There were several other tests where we had fixed that with parseInt so I refactored that to create a new getHitCountInt() method. There are a lot of other tests that are comparing exact hit count strings so I left those as-is.

@LeeDr LeeDr added Team:QA Team label for QA Team release_note:skip Skip the PR/issue when compiling release notes backport:all-open Backport to all branches that could still receive a release labels Oct 24, 2022
@LeeDr LeeDr requested review from marius-dr and liza-mae October 24, 2022 22:30
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-qa (Team:QA)

Copy link
Contributor

@liza-mae liza-mae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for x-pack/test/upgrade

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Member

@marius-dr marius-dr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LeeDr LeeDr merged commit 1cd4c48 into elastic:main Oct 25, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 25, 2022
* refactor getHitCount, use Last_1 year

* revert change to heartbeat test

(cherry picked from commit 1cd4c48)
@kibanamachine
Copy link
Contributor

💔 Some backports could not be created

Status Branch Result
7.17 Backport failed because of merge conflicts
8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 143912

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 25, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* refactor getHitCount, use Last_1 year

* revert change to heartbeat test

(cherry picked from commit 1cd4c48)

Co-authored-by: Lee Drengenberg <[email protected]>
@LeeDr
Copy link
Author

LeeDr commented Oct 25, 2022

💚 All backports created successfully

Status Branch Result
7.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

LeeDr pushed a commit that referenced this pull request Oct 25, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
* resolve merge conflict

* revert change to upgrade/../discover_smoke_test
@mistic mistic added v8.5.1 and removed v8.5.0 labels Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:all-open Backport to all branches that could still receive a release release_note:skip Skip the PR/issue when compiling release notes Team:QA Team label for QA Team v7.17.8 v8.5.1 v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants