-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor getHitCount, use Last_1 year #143912
Conversation
Pinging @elastic/kibana-qa (Team:QA) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for x-pack/test/upgrade
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* refactor getHitCount, use Last_1 year * revert change to heartbeat test (cherry picked from commit 1cd4c48)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run:
Questions ?Please refer to the Backport tool documentation |
* refactor getHitCount, use Last_1 year * revert change to heartbeat test (cherry picked from commit 1cd4c48) Co-authored-by: Lee Drengenberg <[email protected]>
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Summary
NOTE: The tests in this PR don't run as a part of the regular Kibana CI.
In
x-pack/test/upgrade/apps/discover/discover_smoke_tests.ts
I hit a failure after changing the time span of the test toLast_1 year
because the hit count was a string including the comma-separator like"9,340"
and that didn't compare greater than the int 0. There were several other tests where we had fixed that with parseInt so I refactored that to create a new getHitCountInt() method. There are a lot of other tests that are comparing exact hit count strings so I left those as-is.