[Guided onboarding] Copy updates for the Security guide #143868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuliacech
added
release_note:skip
|
Pinging @elastic/platform-onboarding (Team:Journey/Onboarding) |
| @@ -9,22 +9,20 @@ | |||
| import type { GuideConfig } from '../../types'; | |||
|
|
|||
| export const securityConfig: GuideConfig = { | |||
| title: 'Get started with SIEM', | |||
| title: 'Elastic Security guided setup', | |||
There was a problem hiding this comment.
Do you mind updating the strings to use i18n as part of this PR?
There was a problem hiding this comment.
yes, I completely forgot about it, thanks a lot!
kellyemurphy
suggested changes
Oct 24, 2022
src/plugins/guided_onboarding/public/constants/guides_config/security.ts
Outdated
Show resolved
Hide resolved
src/plugins/guided_onboarding/public/constants/guides_config/security.ts
Outdated
Show resolved
Hide resolved
src/plugins/guided_onboarding/public/constants/guides_config/security.ts
Outdated
Show resolved
Hide resolved
…ecurity.ts Co-authored-by: Kelly Murphy <[email protected]>
…ecurity.ts Co-authored-by: Kelly Murphy <[email protected]>
…ecurity.ts Co-authored-by: Kelly Murphy <[email protected]>
|
Thanks a lot for your review, @kellyemurphy! I committed your suggestions and also added a screenshot for "Step 2 manual completion". It's when the user already enabled the rules needed for the guide but they can enable more if they want. Could you please have another look? |
alisonelizabeth
approved these changes
Oct 25, 2022
| defaultMessage: 'Load the prebuilt rules.', | ||
| }), | ||
| i18n.translate('guidedOnboarding.securityGuide.rulesStep.description2', { | ||
| defaultMessage: 'Select the rules that you want..', |
There was a problem hiding this comment.
Suggested change
| defaultMessage: 'Select the rules that you want..', | |
| defaultMessage: 'Select the rules that you want.', |
kellyemurphy
approved these changes
Oct 26, 2022
src/plugins/guided_onboarding/public/constants/guides_config/security.ts
Outdated
Show resolved
Hide resolved
src/plugins/guided_onboarding/public/constants/guides_config/security.ts
Outdated
Show resolved
Hide resolved
…ecurity.ts Co-authored-by: Kelly Murphy <[email protected]>
…ecurity.ts Co-authored-by: Kelly Murphy <[email protected]>
💚 Build Succeeded
Metrics [docs]Page load bundle
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Partially addresses #139741
This PR updates the filler text with the copy from the figma designs for the Security guide.
Screenshots
Step 1
Step 2
Step 2 manual completion
Step 3
Finished state