Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Metric trendlines design changes #143781

Merged
merged 9 commits into from
Oct 24, 2022
Merged

[Lens] Metric trendlines design changes #143781

merged 9 commits into from
Oct 24, 2022

Conversation

drewdaemon
Copy link
Contributor

@drewdaemon drewdaemon commented Oct 20, 2022 •
edited
Loading

Summary

Closes #143687

Screen.Recording.2022-10-21.at.2.45.03.PM.mov

Checklist

This was referenced Oct 21, 2022
Closed
Merged
@drewdaemon drewdaemon changed the title Metric trendlines design changes [Lens] Metric trendlines design changes Oct 21, 2022
@drewdaemon drewdaemon added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Oct 21, 2022
@drewdaemon drewdaemon marked this pull request as ready for review October 22, 2022 14:14
@drewdaemon drewdaemon requested a review from a team as a code owner October 22, 2022 14:14
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@drewdaemon drewdaemon added the release_note:skip Skip the PR/issue when compiling release notes label Oct 22, 2022
@mbondyra
Copy link
Contributor

@elasticmachine merge upstream

mbondyra
mbondyra approved these changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@mbondyra mbondyra left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the bug with the trendlines right? What do you mean by 'Metric trendlines design changes'?
The bug is fixed and it looks good so approving :)

@drewdaemon
Copy link
Contributor Author

Thanks @mbondyra :)

It also changes some strings and moves some settings within the dimension editor per Michael's request. Sorry for the confusion.

MichaelMarcialis
MichaelMarcialis approved these changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@MichaelMarcialis MichaelMarcialis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those changes, @andrewctate! I've left you one small comment, but this looks good to me otherwise. Approving now.

x-pack/plugins/lens/public/visualizations/metric/dimension_editor.tsx Outdated Show resolved Hide resolved
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.3MB 1.3MB +1.3KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@drewdaemon drewdaemon merged commit 15ef4a0 into elastic:main Oct 24, 2022
@kibanamachine kibanamachine added v8.6.0 backport:skip This commit does not require backporting labels Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbondyra mbondyra mbondyra approved these changes

@MichaelMarcialis MichaelMarcialis MichaelMarcialis approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Lens] Enabling metric trend line should not enable layer deletion
6 participants
@drewdaemon @elasticmachine @mbondyra @kibana-ci @MichaelMarcialis @kibanamachine