Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security solution] Guided onboarding, alerts & cases #143598

Merged
merged 55 commits into from
Oct 27, 2022
Merged
Changes from 1 commit
Commits
Show all changes
55 commits
Select commit Hold shift + click to select a range
818dad9
define guided ob plugin
stephmilovic Oct 4, 2022
e0db543
Merge branch 'main' into guided_onboarding_define
stephmilovic Oct 5, 2022
503c23b
stepping along
stephmilovic Oct 5, 2022
2fbbf37
more wip
stephmilovic Oct 5, 2022
94abf31
cleanup
stephmilovic Oct 5, 2022
f527d31
Merge branch 'main' into guided_onboarding_define
stephmilovic Oct 6, 2022
3378b2c
fixies
stephmilovic Oct 6, 2022
cf5646a
Merge branch 'main' into guided_onboarding_define
stephmilovic Oct 18, 2022
3f8be4d
better
stephmilovic Oct 18, 2022
81a706a
fix merge
stephmilovic Oct 19, 2022
238a5af
hey, thats different now
stephmilovic Oct 19, 2022
caa0380
move code to helpers
stephmilovic Oct 20, 2022
5042d3f
yes
stephmilovic Oct 20, 2022
c7a3a16
Merge branch 'guided_onboarding_define' into guided_onboarding_whack
stephmilovic Oct 20, 2022
e76c1ea
fix it
stephmilovic Oct 20, 2022
68c6a74
Merge branch 'main' into guided_onboarding_define
stephmilovic Oct 24, 2022
7541494
rm some old code
stephmilovic Oct 24, 2022
6ebd473
testing
stephmilovic Oct 24, 2022
883a393
add some fancy tests
stephmilovic Oct 24, 2022
0fac6ff
fix
stephmilovic Oct 24, 2022
5c5ac86
revert
stephmilovic Oct 24, 2022
805d052
better?
stephmilovic Oct 24, 2022
7cc2a2f
more better
stephmilovic Oct 24, 2022
b38991b
more better again
stephmilovic Oct 24, 2022
c2158ee
fix alpha
stephmilovic Oct 24, 2022
f5dd0b8
eh?
stephmilovic Oct 24, 2022
fb5df0f
cleaning
stephmilovic Oct 24, 2022
61f3ccf
rename
stephmilovic Oct 24, 2022
8a1f426
rename
stephmilovic Oct 24, 2022
956e96a
type fix
stephmilovic Oct 25, 2022
c5d0e30
fix translations
stephmilovic Oct 25, 2022
1f77e7c
Merge branch 'main' into guided_onboarding_define
stephmilovic Oct 25, 2022
2f75590
fixies
stephmilovic Oct 25, 2022
9ce04cf
add readme
stephmilovic Oct 25, 2022
499f744
Merge branch 'main' into guided_onboarding_define
kibanamachine Oct 25, 2022
ead7344
Merge branch 'main' into guided_onboarding_define
kibanamachine Oct 25, 2022
ae88fc9
fix obs
stephmilovic Oct 26, 2022
93378e2
Merge branch 'guided_onboarding_define' of github.com:stephmilovic/ki…
stephmilovic Oct 26, 2022
a019401
remove tour from nav
stephmilovic Oct 26, 2022
7738e1f
Merge branch 'main' into guided_onboarding_define
stephmilovic Oct 26, 2022
9b8cc02
fix type
stephmilovic Oct 26, 2022
e718c72
johnnys pr feedback
stephmilovic Oct 26, 2022
4af82c5
rm guided onboarding test from nav
stephmilovic Oct 26, 2022
26b1337
fix
stephmilovic Oct 26, 2022
ba8b78c
only use context in detections paths
stephmilovic Oct 26, 2022
251a42e
fix tests
stephmilovic Oct 26, 2022
e09574a
fix possible side effect
stephmilovic Oct 26, 2022
aa676d5
remove step arg
stephmilovic Oct 26, 2022
9d5f20b
Merge branch 'main' into guided_onboarding_define
stephmilovic Oct 27, 2022
9717786
make better
stephmilovic Oct 27, 2022
d0c8a92
Merge branch 'main' into guided_onboarding_define
kibanamachine Oct 27, 2022
c0f35b9
fix for mr michael
stephmilovic Oct 27, 2022
1958a5a
add feature flag
stephmilovic Oct 27, 2022
c2c43d7
mock feature flag (duh)
stephmilovic Oct 27, 2022
aa53370
fix warning in tests
stephmilovic Oct 27, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix for mr michael
stephmilovic committed Oct 27, 2022
commit c0f35b98142cd61a64c6fd8bef0a3ce4c2d99186
Original file line number Diff line number Diff line change
@@ -406,14 +406,19 @@ const EventDetailsComponent: React.FC<Props> = ({
[tabs, selectedTabId]
);

const tourAnchor = useMemo(
() => (isTourAnchor ? { 'tour-step': getTourAnchor(3, SecurityStepId.alertsCases) } : {}),
[isTourAnchor]
);

return (
<GuidedOnboardingTourStep
isTourAnchor={isTourAnchor}
step={3}
stepId={SecurityStepId.alertsCases}
>
<StyledEuiTabbedContent
{...(isTourAnchor ? { 'tour-step': getTourAnchor(3, SecurityStepId.alertsCases) } : {})}
{...tourAnchor}
data-test-subj="eventDetails"
tabs={tabs}
selectedTab={selectedTab}
Original file line number Diff line number Diff line change
@@ -5,7 +5,7 @@
* 2.0.
*/

import React, { useMemo } from 'react';
import React, { useCallback, useMemo } from 'react';

import type { EuiTourStepProps } from '@elastic/eui';
import { EuiButton, EuiImage, EuiSpacer, EuiText, EuiTourStep } from '@elastic/eui';
@@ -25,6 +25,7 @@ export const SecurityTourStep = ({ children, step, stepId }: SecurityTourStep) =
() => securityTourConfig[stepId].find((config) => config.step === step),
[step, stepId]
);
const onClick = useCallback(() => incrementStep(stepId), [incrementStep, stepId]);
// step === 5 && stepId === SecurityStepId.alertsCases is in Cases app and out of context.
// If we mount this step, we know we need to render it
// we are also managing the context on the siem end in the background
@@ -38,7 +39,7 @@ export const SecurityTourStep = ({ children, step, stepId }: SecurityTourStep) =
const footerAction: EuiTourStepProps['footerAction'] = !hideNextButton ? (
<EuiButton
size="s"
onClick={() => incrementStep(stepId)}
onClick={onClick}
color="success"
data-test-subj="onboarding--securityTourNextStepButton"
tour-step="nextButton"
Original file line number Diff line number Diff line change
@@ -211,7 +211,6 @@ const ActionsComponent: React.FC<ActionProps> = ({
() =>
isTourShown(SecurityStepId.alertsCases) &&
eventType === 'signal' &&
// TODO: Steph make sure this is right
isDetectionsAlertsTable(timelineId) &&
ariaRowindex === 1,
[isTourShown, ariaRowindex, eventType, timelineId]