-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add readonly view to user management #143438
Add readonly view to user management #143438
Conversation
Pinging @elastic/kibana-security (Team:Security) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like your reusable components!
Besides a few questions that I added as comments, I only found a single bug: Each role in the "Roles" column in the users table is clickable. It links to the edit-role screen. I guess it should link to the view-role screen in this case. But I'm not sure if the PR that introduces a read-only mode for roles has already been merged?
@@ -69,7 +74,6 @@ export class UsersGridPage extends Component<Props, State> { | |||
isTableLoading: false, | |||
}; | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: did you mean to delete this line?
x-pack/plugins/security/public/management/users/edit_user/create_user_page.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this PR technically should depend on a read-only view for the role screen, it's not a big deal as 1) that PR will land in main
soon after this one, and 2) this read_security
permission is still rather unknown.
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
Resolves #141799
Summary
Add readonly view to manage users screen.
Components
useCapabilities
- Returns capabilities for a specific feature, or alternatively the entire capabilities object.useBadge
- Renders a badge in the Kibana chrome.ReadonlyBadge
- Renders a readonly badge in the Kibana chrome for a given feature when user does not havesave
privileges.Screenshots
Users
Edit user