Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cases]: Removed shared_imports from cases #143427

Merged
merged 2 commits into from
Oct 17, 2022
Merged

[Cases]: Removed shared_imports from cases #143427

merged 2 commits into from
Oct 17, 2022

Conversation

arpitbhardwaj
Copy link
Contributor

@arpitbhardwaj arpitbhardwaj commented Oct 17, 2022 •
edited by cnasikas
Loading

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

  • Deleted the file x-pack/plugins/cases/public/common/shared_imports.ts
  • Changes in consumers imports what they need directly from the (@kbn/es-ui-shared-plugin/static/forms/hook_form_lib, @kbn/es-ui-shared-plugin/static/forms/components, @kbn/es-ui-shared-plugin/static/forms/helpers, @kbn/es-ui-shared-plugin/static/forms/helpers/field_validators/types).

Refer #139980

For maintainers

@arpitbhardwaj arpitbhardwaj requested a review from a team as a code owner October 17, 2022 09:44
@kibanamachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cnasikas cnasikas added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature v8.6.0 labels Oct 17, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@cnasikas cnasikas linked an issue Oct 17, 2022 that may be closed by this pull request
[Cases] Remove shared_imports #139980
Closed
@cnasikas
Copy link
Member

buildkite test this

@cnasikas
Copy link
Member

@elasticmachine, run elasticsearch-ci/docs

cnasikas
cnasikas approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@cnasikas cnasikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM! Thank you for your contribution!

@cnasikas
Copy link
Member

@elasticmachine merge upstream

@cnasikas
Copy link
Member

buildkite test this

@cnasikas
Copy link
Member

@elasticmachine, run elasticsearch-ci/docs

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
cases 501 500 -1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 372.3KB 372.3KB -11.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cnasikas cnasikas merged commit 4234417 into elastic:main Oct 17, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cnasikas cnasikas cnasikas approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting 💝community Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Cases] Remove shared_imports
5 participants
@arpitbhardwaj @kibanamachine @elasticmachine @cnasikas @kibana-ci