[Synthetics] Fix monitor details project monitor view #143258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzad31
added
release_note:skip
botelastic
bot
added
the
Team:Uptime - DEPRECATED
|
Pinging @elastic/uptime (Team:uptime) |
afgomez
reviewed
Oct 13, 2022
...plugins/synthetics/public/apps/synthetics/components/monitor_details/hooks/use_monitor_id.ts
Outdated
Show resolved
Hide resolved
| latestPing.observer?.geo?.name === locationLabel; | ||
| const latestPingId = latestPing?.monitor.id; | ||
|
|
||
| const isIdSame = |
There was a problem hiding this comment.
Take into account that both latestPingId and monitorId might be undefined, and in that case this will evaluate to true.
afgomez
reviewed
Oct 14, 2022
shahzad31
force-pushed
the
fix-project-view
branch
from
e4eb1d2 to
813741a
Compare
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
To update your PR or re-run it, just comment with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #143059
Fixes monitor details view for project monitors.
Uses custom_heartbeat_id for data instead of monitor.id if monitor origin is of type project !!
After:
Before: