Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.4] add a dismiss to the uptime tour popup (#142879) #142942

Merged
merged 4 commits into from
Oct 8, 2022
Merged

[8.4] add a dismiss to the uptime tour popup (#142879) #142942

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b5d21d6
add a dismiss to the uptime tour popup (#142879)
marius-dr Oct 6, 2022
c600d65
Merge branch '8.4' into backport/8.4/pr-142879
kibanamachine Oct 7, 2022
1605b89
add tour dismiss method
marius-dr Oct 8, 2022
fdd3c68
[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…
kibanamachine Oct 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions x-pack/test/functional/page_objects/uptime_page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,10 @@ export class UptimePageObject extends FtrService {
}
}

public async dismissTour() {
await this.testSubjects.click('syntheticsManagementTourDismiss');
}

public async setDateRange(start: string, end: string) {
const { start: prevStart, end: prevEnd } = await this.timePicker.getTimeConfig();
if (start !== prevStart || prevEnd !== end) {
Expand Down
1 change: 1 addition & 0 deletions x-pack/test/stack_functional_integration/apps/heartbeat/_heartbeat.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
describe('check heartbeat overview page', function () {
it('Uptime app should show 1 UP monitor', async function () {
await PageObjects.common.navigateToApp('uptime', { insertTimestamp: false });
await PageObjects.uptime.dismissTour();
await PageObjects.timePicker.setCommonlyUsedTime('Last_1 year');

await retry.try(async function () {
Expand Down