Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stack Functional Integration] Dismiss to the uptime tour pop-up #142879

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

marius-dr
Copy link
Member

@marius-dr marius-dr commented Oct 6, 2022

Summary

We need to dismiss the uptime tour pop-up in the test because it interferes with the timepicker selection during our tests.

@marius-dr marius-dr added test Team:QA Team label for QA Team release_note:skip Skip the PR/issue when compiling release notes test-stack-integration backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.6.0 labels Oct 6, 2022
@marius-dr marius-dr requested a review from LeeDr October 6, 2022 15:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-qa (Team:QA)

@marius-dr marius-dr enabled auto-merge (squash) October 6, 2022 15:40
Copy link

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - code review only

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@marius-dr marius-dr merged commit a873c3f into main Oct 6, 2022
@marius-dr marius-dr deleted the fix_uptime_test_mariusdr branch October 6, 2022 16:33
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 6, 2022
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@marius-dr
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
8.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

marius-dr added a commit that referenced this pull request Oct 8, 2022
* add a dismiss to the uptime tour popup (#142879)

(cherry picked from commit a873c3f)

* add tour dismiss method

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

Co-authored-by: Kibana Machine <[email protected]>
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:QA Team label for QA Team test test-stack-integration v8.4.4 v8.5.0 v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants