Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Failing test: Jest Tests.x-pack/plugins/lens/common/expressions/time_scale - time_scale should work with relative time range #142837

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Oct 6, 2022

Closes: #142820

Summary

Fix Failing test: Jest Tests.x-pack/plugins/lens/common/expressions/time_scale - time_scale should work with relative time range

Notes

Tested locally, 100 runs were stable

for i in {1..100}; do node scripts/jest x-pack/plugins/lens/common/expressions/time_scale/time_scale.test.ts ; done

…ime_scale - time_scale should work with relative time range

Closes: elastic#142820
@alexwizp alexwizp added the v8.6.0 label Oct 6, 2022
@alexwizp alexwizp self-assigned this Oct 6, 2022
@alexwizp alexwizp added release_note:skip Skip the PR/issue when compiling release notes failed-test A test failure on a tracked branch, potentially flaky-test Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Oct 6, 2022
@alexwizp alexwizp marked this pull request as ready for review October 6, 2022 12:08
@alexwizp alexwizp requested a review from a team as a code owner October 6, 2022 12:08
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alexwizp

Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, code review only

@flash1293
Copy link
Contributor

Going ahead and merging this as the test is very flaky

@flash1293 flash1293 added the backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) label Oct 6, 2022
@flash1293 flash1293 merged commit 42f0868 into elastic:main Oct 6, 2022
@alexwizp alexwizp added backport:skip This commit does not require backporting and removed backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Oct 6, 2022
@elastic elastic deleted a comment from kibanamachine Oct 6, 2022
alexwizp added a commit to alexwizp/kibana that referenced this pull request Oct 7, 2022
…ime_scale - time_scale should work with relative time range (elastic#142837)

Closes: elastic#142820
(cherry picked from commit 42f0868)
@alexwizp
Copy link
Contributor Author

alexwizp commented Oct 7, 2022

💚 All backports created successfully

Status Branch Result
8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

alexwizp added a commit that referenced this pull request Oct 7, 2022
…ime_scale - time_scale should work with relative time range (#142837) (#142937)

Closes: #142820
(cherry picked from commit 42f0868)
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
…ime_scale - time_scale should work with relative time range (elastic#142837)

Closes: elastic#142820
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
…ime_scale - time_scale should work with relative time range (elastic#142837)

Closes: elastic#142820
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting failed-test A test failure on a tracked branch, potentially flaky-test release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.5.0 v8.6.0
Projects
None yet
5 participants