[8.6][ML Inference] New API to fetch ML inference errors #142799

demjened · 2022-10-05T21:00:04Z

Summary

This PR adds a new endpoint for fetching aggregated ML inference errors from the target index. It returns the error message, affected document count, and the last error's timestamp for each distinct error.

Endpoint

GET /internal/enterprise_search/indices/{indexName}/ml_inference/errors

Sample response

{
    "errors": [
        {
            "message": "Processor 'inference' in pipeline 'ml-inference-my-ner-pipeline' failed with message 'Trained model [philschmid__distilroberta-base-ner-conll2003] is not deployed.'",
            "doc_count": 21,
            "timestamp": "2022-10-05T13:50:36.619Z"
        },
        {
            "message": "Processor 'inference' in pipeline 'ml-inference-my-text-embedding-pipeline' failed with message 'Input field [text_field] does not exist in the source document'",
            "doc_count": 21,
            "timestamp": "2022-10-05T13:50:36.619Z"
        }
    ]
}

Checklist

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios

…-fix'

…jened/kibana into create-ml-inference-pipeline

…-fix'

…-ref HEAD~1..HEAD --fix'

…-fix'

…-ref HEAD~1..HEAD --fix'

…-fix'

…-ref HEAD~1..HEAD --fix'

…-fix'

…-ref HEAD~1..HEAD --fix'

…-fix'

kibana-ci · 2022-10-05T23:52:47Z

💚 Build Succeeded

Buildkite Build
Commit: a10fb33

Metrics [docs]

✅ unchanged

History

💔 Build #78546 failed ec53fe6e2b53bf484c1768efeed4dd0da2225fb1

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

TattdCodeMonkey · 2022-10-06T14:22:35Z

x-pack/plugins/enterprise_search/server/lib/ml_inference_pipeline/get_inference_errors.ts

+
+import { ElasticsearchClient } from '@kbn/core/server';
+
+export interface MlInferenceError {


This should be defined in the common/types folder so we can import it from the frontend when calling this API.

I'll refactor this in the frontend follow-up PR.

TattdCodeMonkey · 2022-10-06T14:27:29Z

x-pack/plugins/enterprise_search/server/lib/ml_inference_pipeline/get_inference_errors.ts

+
+import { ElasticsearchClient } from '@kbn/core/server';
+
+export interface MlInferenceError {


I'll refactor this in the frontend follow-up PR.

brianmcgue · 2022-10-06T17:29:42Z

x-pack/plugins/enterprise_search/server/lib/ml_inference_pipeline/get_inference_errors.ts

+  const searchResult = await esClient.search<
+    unknown,
+    {
+      errors: AggregationsMultiBucketAggregateBase<ErrorAggregationBucket>;


Why is there a semicolon at the end of this line? 🤔

It is a type declaration, so it follows the same pattern similar to the line 21

) * Add ML inference PL creation flow * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * Add exists check, clean up code a bit * Fix dest name * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * Separate concerns * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' * Remove i18n due to linter error, fix src field ref * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' * Add/update unit tests * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' * Refactor error handling * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * Add sub-pipeline to parent ML PL * Add unit tests and docs * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * Refactor error handling * Wrap logic into higher level function * Add route test * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * API to fetch inference errors * Minor style changes * Add unit tests * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' Co-authored-by: kibanamachine <[email protected]>

demjened and others added 30 commits September 13, 2022 13:47

Add ML inference PL creation flow

c9a0545

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

e293860

…-fix'

Add exists check, clean up code a bit

8fb6d63

Merge branch 'create-ml-inference-pipeline' of https://github.com/dem…

05f5eb2

…jened/kibana into create-ml-inference-pipeline

Fix dest name

d69478b

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

2443d8c

…-fix'

Separate concerns

49aebdb

[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…

aee672f

…-ref HEAD~1..HEAD --fix'

Remove i18n due to linter error, fix src field ref

d838052

[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…

f4d53ba

…-ref HEAD~1..HEAD --fix'

Add/update unit tests

ef14bad

[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…

5d3b37d

…-ref HEAD~1..HEAD --fix'

Refactor error handling

8613f5b

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

b972688

…-fix'

Add sub-pipeline to parent ML PL

92b4ec5

Add unit tests and docs

71bf27b

[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…

7c74509

…-ref HEAD~1..HEAD --fix'

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

0ecad7e

…-fix'

Merge branch 'main' into create-ml-inference-pipeline

ce8f0a7

Refactor error handling

1c15559

Wrap logic into higher level function

bf29f2a

Add route test

aaae199

[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…

9d2f232

…-ref HEAD~1..HEAD --fix'

Merge branch 'main' into create-ml-inference-pipeline

99a7027

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

63c52cb

…-fix'

Merge branch 'create-ml-inference-pipeline'

85a5020

Merge branch 'main' of https://github.com/elastic/kibana

1f70e59

Merge branch 'main' of https://github.com/elastic/kibana

58f6524

Merge branch 'main' of https://github.com/elastic/kibana

27028f8

Merge branch 'main' of https://github.com/elastic/kibana

8acd6a3

demjened added 4 commits September 26, 2022 13:42

Merge branch 'main' of https://github.com/elastic/kibana

2ab2dd1

Merge branch 'main' of https://github.com/elastic/kibana

397851e

Merge branch 'main' of https://github.com/elastic/kibana

5248c96

API to fetch inference errors

60360fe

demjened force-pushed the demjened/api-fetch-ml-inference-errors branch from ec53fe6 to 60360fe Compare October 5, 2022 21:18

demjened added 2 commits October 5, 2022 18:01

Minor style changes

2f28e1c

Add unit tests

d7b98f5

demjened force-pushed the demjened/api-fetch-ml-inference-errors branch from 8d5c1f9 to d7b98f5 Compare October 5, 2022 22:12

demjened added backport:skip This commit does not require backporting Team:EnterpriseSearch v8.6.0 labels Oct 5, 2022

demjened changed the title ~~[WIP][8.6][ML Inference] New API to fetch ML inference errors~~ [8.6][ML Inference] New API to fetch ML inference errors Oct 5, 2022

[CI] Auto-commit changed files from 'node scripts/precommit_hook.js -…

0668a58

…-ref HEAD~1..HEAD --fix'

demjened requested review from TattdCodeMonkey and brianmcgue October 5, 2022 22:21

demjened marked this pull request as ready for review October 5, 2022 22:24

demjened requested a review from a team October 5, 2022 22:24

demjened added the release_note:feature Makes this part of the condensed release notes label Oct 5, 2022

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

a10fb33

…-fix'

TattdCodeMonkey reviewed Oct 6, 2022

View reviewed changes

TattdCodeMonkey approved these changes Oct 6, 2022

View reviewed changes

TattdCodeMonkey added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:feature Makes this part of the condensed release notes labels Oct 6, 2022

TattdCodeMonkey merged commit c723fd8 into elastic:main Oct 6, 2022

brianmcgue reviewed Oct 6, 2022

View reviewed changes

demjened deleted the demjened/api-fetch-ml-inference-errors branch October 14, 2022 18:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[8.6][ML Inference] New API to fetch ML inference errors #142799

[8.6][ML Inference] New API to fetch ML inference errors #142799

demjened commented Oct 5, 2022 •

edited

Loading

kibana-ci commented Oct 5, 2022

TattdCodeMonkey Oct 6, 2022

TattdCodeMonkey Oct 6, 2022

TattdCodeMonkey Oct 6, 2022

brianmcgue Oct 6, 2022

efegurkan Oct 10, 2022


		import { ElasticsearchClient } from '@kbn/core/server';

		export interface MlInferenceError {

[8.6][ML Inference] New API to fetch ML inference errors #142799

[8.6][ML Inference] New API to fetch ML inference errors #142799

Conversation

demjened commented Oct 5, 2022 • edited Loading

Summary

Checklist

kibana-ci commented Oct 5, 2022

💚 Build Succeeded

Metrics [docs]

History

TattdCodeMonkey Oct 6, 2022

Choose a reason for hiding this comment

TattdCodeMonkey Oct 6, 2022

Choose a reason for hiding this comment

TattdCodeMonkey Oct 6, 2022

Choose a reason for hiding this comment

brianmcgue Oct 6, 2022

Choose a reason for hiding this comment

efegurkan Oct 10, 2022

Choose a reason for hiding this comment

demjened commented Oct 5, 2022 •

edited

Loading