-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Explain Log Rate Spikes: update more groups badge for clarity #142793
[ML] Explain Log Rate Spikes: update more groups badge for clarity #142793
Conversation
Pinging @elastic/ml-ui (:ml) |
x-pack/plugins/aiops/public/components/spike_analysis_table/spike_analysis_table_groups.tsx
Outdated
Show resolved
Hide resolved
I find the combination of tooltip and "+more" text confusing. The tooltip says "Displays field values unique to the group. Expand row to see all values." I interpret this to mean that when the row isn't expanded, I see the unique values; when the row is expanded, I see all values (including non-unique ones)". However the "+more" seems to hide the non-unique values. How do I see those (do I have to click something to expand further)? I didn't have time to play with this myself today, but am happy to discuss text options further when I better understand what the desired behavior is. |
Thanks for taking a look, @lcawl 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ah, I was confused because I thought those rows were already expanded in the screenshot. Thanks for the clarification! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
…lastic#142793) * update more groups badge for clarity * update copy in tooltip and group badge (cherry picked from commit ca04402)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
…142793) (#142899) * update more groups badge for clarity * update copy in tooltip and group badge (cherry picked from commit ca04402) Co-authored-by: Melissa Alvarez <[email protected]>
…lastic#142793) * update more groups badge for clarity * update copy in tooltip and group badge
…lastic#142793) * update more groups badge for clarity * update copy in tooltip and group badge
Summary
Related issue: #142626
This PR updates the group badge copy representing more groups not immediately shown in the row. Instead of
+ 5 more
, for example, the badge now reads+5 more field names and values also appearing in other groups
This language is consistent with the tooltip copy for that column.
Checklist
Delete any items that are not applicable to this PR.