Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Explain Log Rate Spikes: update more groups badge for clarity #142793

Merged

Conversation

alvarezmelissa87
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 commented Oct 5, 2022

Summary

Related issue: #142626

This PR updates the group badge copy representing more groups not immediately shown in the row. Instead of + 5 more, for example, the badge now reads+5 more field names and values also appearing in other groups

This language is consistent with the tooltip copy for that column.

image

Checklist

Delete any items that are not applicable to this PR.

@alvarezmelissa87 alvarezmelissa87 added :ml v8.5.0 Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis v8.6.0 labels Oct 5, 2022
@alvarezmelissa87 alvarezmelissa87 self-assigned this Oct 5, 2022
@alvarezmelissa87 alvarezmelissa87 requested a review from a team as a code owner October 5, 2022 19:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@lcawl
Copy link
Contributor

lcawl commented Oct 5, 2022

I find the combination of tooltip and "+more" text confusing. The tooltip says "Displays field values unique to the group. Expand row to see all values." I interpret this to mean that when the row isn't expanded, I see the unique values; when the row is expanded, I see all values (including non-unique ones)". However the "+more" seems to hide the non-unique values. How do I see those (do I have to click something to expand further)?

I didn't have time to play with this myself today, but am happy to discuss text options further when I better understand what the desired behavior is.

@alvarezmelissa87
Copy link
Contributor Author

I find the combination of tooltip and "+more" text confusing. The tooltip says "Displays field values unique to the group. Expand row to see all values." I interpret this to mean that when the row isn't expanded, I see the unique values; when the row is expanded, I see all values (including non-unique ones)". However the "+more" seems to hide the non-unique values. How do I see those (do I have to click something to expand further)?

I didn't have time to play with this myself today, but am happy to discuss text options further when I better understand what the desired behavior is.

Thanks for taking a look, @lcawl 🙏
So the +more will sometimes be the only badge because that particular group doesn't have any unique values. So expanding the row would show all values in the group but none of them are unique across the groups.

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lcawl
Copy link
Contributor

lcawl commented Oct 6, 2022

Thanks for taking a look, @lcawl 🙏 So the +more will sometimes be the only badge because that particular group doesn't have any unique values. So expanding the row would show all values in the group but none of them are unique across the groups.

Ah, I was confused because I thought those rows were already expanded in the screenshot. Thanks for the clarification!

@lcawl lcawl added the ui-copy Review of UI copy with docs team is recommended label Oct 6, 2022
Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #10 / machine learning - data visualizer field statistics in Discover when enabled with lucene saved search displays the 'Field statistics' table content correctly

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 766.5KB 766.5KB +65.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alvarezmelissa87

@alvarezmelissa87 alvarezmelissa87 merged commit ca04402 into elastic:main Oct 6, 2022
@alvarezmelissa87 alvarezmelissa87 deleted the ml-aiops-group-badge-copy-fix branch October 6, 2022 18:15
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 6, 2022
…lastic#142793)

* update more groups badge for clarity

* update copy in tooltip and group badge

(cherry picked from commit ca04402)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 6, 2022
…142793) (#142899)

* update more groups badge for clarity

* update copy in tooltip and group badge

(cherry picked from commit ca04402)

Co-authored-by: Melissa Alvarez <[email protected]>
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
…lastic#142793)

* update more groups badge for clarity

* update copy in tooltip and group badge
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
…lastic#142793)

* update more groups badge for clarity

* update copy in tooltip and group badge
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis :ml release_note:fix ui-copy Review of UI copy with docs team is recommended v8.5.0 v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants