Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Use 4 parallel ESLint jobs #142787

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

tylersmalley
Copy link
Contributor

@tylersmalley tylersmalley commented Oct 5, 2022

We're seeing some odd flakiness with ESLint on CI

https://buildkite.com/elastic/kibana-on-merge/builds/22145#0183a956-8408-41ec-96fd-fb3fa37a2ae8

Error: .eslintrc.js » @kbn/eslint-config » ./javascript.js#overrides[0]:
	Configuration for rule "camelcase" is invalid:
Unexpected token ','

The only thing that we came up with was the seemingly high CPU. So, we're dropping the parallelization to test the assumption. This takes the lining task to ~32minutes from ~29.

Signed-off-by: Tyler Smalley <[email protected]>
@tylersmalley tylersmalley added Team:Operations Team label for Operations Team v8.5.1 labels Oct 5, 2022
@tylersmalley tylersmalley marked this pull request as ready for review October 5, 2022 19:53
@tylersmalley tylersmalley requested a review from a team as a code owner October 5, 2022 19:53
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tylersmalley tylersmalley added the release_note:skip Skip the PR/issue when compiling release notes label Oct 5, 2022
@tylersmalley tylersmalley enabled auto-merge (squash) October 5, 2022 19:55
@tylersmalley tylersmalley merged commit 47354fa into elastic:main Oct 5, 2022
@tylersmalley tylersmalley deleted the eslint-4-parallel branch October 5, 2022 19:59
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 5, 2022
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 5, 2022
(cherry picked from commit 47354fa)

Co-authored-by: Tyler Smalley <[email protected]>
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v8.5.0 v8.5.1 v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants