Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Synthetics] Update layout for ping monitor #142779

Merged
merged 1 commit into from
Oct 6, 2022
Merged

[Synthetics] Update layout for ping monitor #142779

merged 1 commit into from
Oct 6, 2022

Conversation

shahzad31
Copy link
Contributor

Summary

Update layout for ping monitor , instead of step duration just display monitor duration , also made improvement on description group layout

After:

image

Before

image

@shahzad31 shahzad31 requested a review from a team as a code owner October 5, 2022 17:21
@botelastic botelastic bot added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Oct 5, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@shahzad31 shahzad31 added v8.6.0 release_note:skip Skip the PR/issue when compiling release notes labels Oct 5, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
synthetics 1.0MB 1.0MB +198.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

awahab07
awahab07 approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@awahab07 awahab07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shahzad31 shahzad31 merged commit 61630e3 into elastic:main Oct 6, 2022
@shahzad31 shahzad31 deleted the summary-layout branch October 6, 2022 08:14
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 6, 2022
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
@shahzad31 @WafaaNasr
[Synthetics] Update layout for ping monitor (elastic#142779)
03d72dc
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
@shahzad31 @WafaaNasr
[Synthetics] Update layout for ping monitor (elastic#142779)
d4a0b36
@dominiqueclarke dominiqueclarke self-requested a review November 21, 2022 15:20
@dominiqueclarke
Copy link
Contributor

Layout LGTM in Post FF testing

Screen Shot 2022-11-21 at 10 35 40 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awahab07 awahab07 awahab07 approved these changes

@dominiqueclarke dominiqueclarke Awaiting requested review from dominiqueclarke

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shahzad31 @elasticmachine @kibana-ci @dominiqueclarke @awahab07 @kibanamachine