-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Profiling] Auto-abort requests #142750
[Profiling] Auto-abort requests #142750
Conversation
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
To update your PR or re-run it, just comment with: |
I'll test tomorrow morning locally. |
@rockdaboot yeah, that's no problem. The commit gets squashed and all that is left is the diff. That one gets backported. (Sorry other Tim R 🥲) |
Nevertheless I find this a great enhancement. Let's not waste those resources for the query if the user already doesn't care about the response! Approve 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and works as expected!
I tested these use cases:
- load tested using 10 parallel runs and then canceled after a few seconds
- switched back-and-forth between flamegraph and differential flamegraph multiple times for a large time range
- switched back-and-forth between TopN functions and differential TopN functions multiple times for a large time range
For all cases, the server requests were canceled and the "Request aborted" was logged. I did not see the server errors about aborted requests as I had seen previously.
It was difficult to test the TopN stacktraces since the requests completed so quickly.
@timroes 😄 hope you're well! |
(cherry picked from commit c05190e)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
(cherry picked from commit c05190e) Co-authored-by: Dario Gieselaar <[email protected]>
Auto-abort requests when the user navigates away from the page or a new request is started.