Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update short URL access fields on resolution by slug #142731

Merged
merged 6 commits into from
Oct 5, 2022
Merged

Update short URL access fields on resolution by slug #142731

merged 6 commits into from
Oct 5, 2022

Conversation

vadimkibana
Copy link
Contributor

@vadimkibana vadimkibana commented Oct 5, 2022 •
edited
Loading

Summary

Closes #142730

Updates accessDate and accessCount on short URL when short URL is being "resolved" by its slug.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@vadimkibana vadimkibana changed the title update short url access fields on resolution by slug Update short URL access fields on resolution by slug Oct 5, 2022
@vadimkibana vadimkibana added review Feature:SharingURLs Short URLs and Share URL features release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:AppServicesUx v8.6.0 labels Oct 5, 2022
@vadimkibana vadimkibana marked this pull request as ready for review October 5, 2022 12:15
@vadimkibana vadimkibana requested a review from a team as a code owner October 5, 2022 12:15
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesUx)

ppisljar
ppisljar approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@vadimkibana vadimkibana merged commit 6b1e448 into elastic:main Oct 5, 2022
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
@vadimkibana @kibanamachine @WafaaNasr
Update short URL access fields on resolution by slug (elastic#142731)
472446b 
* update short url access fields on resolution by slug

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* improve field update method

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* [CI] Auto-commit changed files from 'node scripts/build_plugin_list_docs'

Co-authored-by: kibanamachine <[email protected]>
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
@vadimkibana @kibanamachine @WafaaNasr
Update short URL access fields on resolution by slug (elastic#142731)
101cc43 
* update short url access fields on resolution by slug

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* improve field update method

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* [CI] Auto-commit changed files from 'node scripts/build_plugin_list_docs'

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppisljar ppisljar ppisljar approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting Feature:SharingURLs Short URLs and Share URL features release_note:skip Skip the PR/issue when compiling release notes review v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update "accessDate" field in short URL when it is accessed
5 participants
@vadimkibana @elasticmachine @kibana-ci @ppisljar @kibanamachine