Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Migrate api tests to use apm api client #142724

Conversation

yngrdyn
Copy link
Contributor

@yngrdyn yngrdyn commented Oct 5, 2022

Relates to 111308.

Removed the usage of:

  • legacySupertestAsApmWriteUser
  • legacySupertestAsApmReadUserWithoutMlAccess

@yngrdyn yngrdyn added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting v8.6.0 labels Oct 5, 2022
@yngrdyn yngrdyn requested review from a team as code owners October 5, 2022 11:03
@yngrdyn yngrdyn changed the title [APM] Removed legacySupertestAsApmWriteUser + legacySupertestAsApmReadUserWithoutMlAccess [APM] Migrate api tests to use apm api client Oct 5, 2022
@yngrdyn yngrdyn force-pushed the migrate-apiTests-to-use-apmApiClient-missing-services branch from 33b9fa8 to 7de369b Compare October 5, 2022 11:17
Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yngrdyn. Much nicer!

@yngrdyn yngrdyn force-pushed the migrate-apiTests-to-use-apmApiClient-missing-services branch from 60b4aa9 to f306b5b Compare October 5, 2022 13:50
@yngrdyn yngrdyn force-pushed the migrate-apiTests-to-use-apmApiClient-missing-services branch from 9be398a to 44ae5c2 Compare October 6, 2022 09:12
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@yngrdyn yngrdyn merged commit 41b2815 into elastic:main Oct 6, 2022
@yngrdyn yngrdyn mentioned this pull request Oct 6, 2022
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
* Removed legacySupertestAsApmWriteUser + legacySupertestAsApmReadUserWithoutMlAccess

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* [CI] Auto-commit changed files from 'node scripts/build_plugin_list_docs'

* Addressing PR changes

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

Co-authored-by: kibanamachine <[email protected]>
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
* Removed legacySupertestAsApmWriteUser + legacySupertestAsApmReadUserWithoutMlAccess

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

* [CI] Auto-commit changed files from 'node scripts/build_plugin_list_docs'

* Addressing PR changes

* [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix'

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants