-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Migrate api tests to use apm api client #142724
Merged
yngrdyn
merged 5 commits into
elastic:main
from
yngrdyn:migrate-apiTests-to-use-apmApiClient-missing-services
Oct 6, 2022
Merged
[APM] Migrate api tests to use apm api client #142724
yngrdyn
merged 5 commits into
elastic:main
from
yngrdyn:migrate-apiTests-to-use-apmApiClient-missing-services
Oct 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yngrdyn
added
release_note:skip
Skip the PR/issue when compiling release notes
backport:skip
This commit does not require backporting
v8.6.0
labels
Oct 5, 2022
yngrdyn
changed the title
[APM] Removed legacySupertestAsApmWriteUser + legacySupertestAsApmReadUserWithoutMlAccess
[APM] Migrate api tests to use apm api client
Oct 5, 2022
yngrdyn
force-pushed
the
migrate-apiTests-to-use-apmApiClient-missing-services
branch
from
October 5, 2022 11:17
33b9fa8
to
7de369b
Compare
…-ref HEAD~1..HEAD --fix'
darnautov
reviewed
Oct 5, 2022
x-pack/test/apm_api_integration/tests/settings/anomaly_detection/write_user.spec.ts
Outdated
Show resolved
Hide resolved
sorenlouv
approved these changes
Oct 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yngrdyn. Much nicer!
yngrdyn
force-pushed
the
migrate-apiTests-to-use-apmApiClient-missing-services
branch
from
October 5, 2022 13:50
60b4aa9
to
f306b5b
Compare
darnautov
approved these changes
Oct 5, 2022
yngrdyn
force-pushed
the
migrate-apiTests-to-use-apmApiClient-missing-services
branch
from
October 6, 2022 09:12
9be398a
to
44ae5c2
Compare
…-ref HEAD~1..HEAD --fix'
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
WafaaNasr
pushed a commit
to WafaaNasr/kibana
that referenced
this pull request
Oct 11, 2022
* Removed legacySupertestAsApmWriteUser + legacySupertestAsApmReadUserWithoutMlAccess * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' * [CI] Auto-commit changed files from 'node scripts/build_plugin_list_docs' * Addressing PR changes * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' Co-authored-by: kibanamachine <[email protected]>
WafaaNasr
pushed a commit
to WafaaNasr/kibana
that referenced
this pull request
Oct 14, 2022
* Removed legacySupertestAsApmWriteUser + legacySupertestAsApmReadUserWithoutMlAccess * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' * [CI] Auto-commit changed files from 'node scripts/build_plugin_list_docs' * Addressing PR changes * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' Co-authored-by: kibanamachine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
release_note:skip
Skip the PR/issue when compiling release notes
v8.6.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to 111308.
Removed the usage of:
legacySupertestAsApmWriteUser
legacySupertestAsApmReadUserWithoutMlAccess