Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Fix react warning messages in the editor #142712

Merged
merged 3 commits into from
Oct 5, 2022
Merged

[Lens] Fix react warning messages in the editor #142712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
85f2513
:lipstick: Fix react warnings
dej611 Oct 5, 2022
3ccadca
Merge remote-tracking branch 'upstream/main' into fix/button-icon-ari…
dej611 Oct 5, 2022
e20c1cc
[CI] Auto-commit changed files from 'node scripts/build_plugin_list_d…
kibanamachine Oct 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/developer/plugin-list.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ as uiSettings within the code.

|{kib-repo}blob/{branch}/src/plugins/data_views/README.mdx[dataViews]
|The data views API provides a consistent method of structuring and formatting documents
and field lists across the various Kibana apps. Its typically used in conjunction with
and field lists across the various Kibana apps. It's typically used in conjunction with
<DocLink id="kibDevTutorialDataSearchAndSessions" section="high-level-search" text="SearchSource" /> for composing queries.


Expand Down
10 changes: 9 additions & 1 deletion x-pack/plugins/lens/public/indexpattern_datasource/dimension_panel/dimension_editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,7 +605,15 @@ export function DimensionEditor(props: DimensionEditorProps) {
...services,
};

const helpButton = <EuiButtonIcon onClick={onHelpClick} iconType="documentation" />;
const helpButton = (
<EuiButtonIcon
onClick={onHelpClick}
iconType="documentation"
aria-label={i18n.translate('xpack.lens.indexPattern.quickFunctions.tableTitle', {
defaultMessage: 'Description of functions',
})}
/>
);

const columnsSidebar = [
{
Expand Down