Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fix after all hook for Notifications tests #142711

Merged
merged 1 commit into from
Oct 5, 2022
Merged

[ML] Fix after all hook for Notifications tests #142711

merged 1 commit into from
Oct 5, 2022

Conversation

darnautov
Copy link
Contributor

@darnautov darnautov commented Oct 5, 2022 •
edited by kibanamachine
Loading

Summary

Fixes #142248

Checklist

@darnautov darnautov added :ml test_ui_functional release_note:skip Skip the PR/issue when compiling release notes Team:ML Team label for ML (also use :ml) v8.5.0 v8.6.0 labels Oct 5, 2022
@darnautov darnautov requested a review from pheyos October 5, 2022 09:54
@darnautov darnautov self-assigned this Oct 5, 2022
@darnautov darnautov requested a review from a team as a code owner October 5, 2022 09:54
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@darnautov darnautov enabled auto-merge (squash) October 5, 2022 09:56
@darnautov
Copy link
Contributor Author

checking with the flaky test runner

@darnautov darnautov disabled auto-merge October 5, 2022 10:29
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @darnautov

jgowdyelastic
jgowdyelastic approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darnautov darnautov merged commit da39215 into elastic:main Oct 5, 2022
@darnautov darnautov deleted the ml-fix-notifications-tests branch October 5, 2022 11:26
@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.5 Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 142711

Questions ?

Please refer to the Backport tool documentation

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add the label auto-backport or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 142711 locally

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 7, 2022
@darnautov darnautov mentioned this pull request Oct 10, 2022
Merged
@darnautov
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
✅ 8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

darnautov added a commit to darnautov/kibana that referenced this pull request Oct 10, 2022
@darnautov
[ML] Fix after all hook for Notifications tests (elastic#142711)
0b6bb88 
(cherry picked from commit da39215)

# Conflicts:
#	x-pack/test/functional/apps/ml/short_tests/notifications/notification_list.ts
darnautov added a commit that referenced this pull request Oct 10, 2022
@darnautov
[ML] Fix after all hook for Notifications tests (#142711) (#142961)
5d68085 
(cherry picked from commit da39215)

# Conflicts:
#	x-pack/test/functional/apps/ml/short_tests/notifications/notification_list.ts
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 10, 2022
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
@darnautov @WafaaNasr
[ML] Fix after all hook for Notifications tests (elastic#142711)
f62816f
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
@darnautov @WafaaNasr
[ML] Fix after all hook for Notifications tests (elastic#142711)
a71e1e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@pheyos pheyos Awaiting requested review from pheyos

@peteharverson peteharverson Awaiting requested review from peteharverson

Assignees

@darnautov darnautov

Labels
:ml release_note:skip Skip the PR/issue when compiling release notes Team:ML Team label for ML (also use :ml) test_ui_functional v8.5.0 v8.6.0
Projects
None yet
Milestone
No milestone
5 participants
@darnautov @elasticmachine @kibana-ci @kibanamachine @jgowdyelastic