Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Add back ticks on bands #142702

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Conversation

flash1293
Copy link
Contributor

@flash1293 flash1293 commented Oct 5, 2022

Fixes #142614

by adding back the existing logic only for color bands.

@flash1293 flash1293 added release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Oct 5, 2022
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
expressionGauge 18.3KB 18.7KB +357.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 marked this pull request as ready for review October 5, 2022 10:02
@flash1293 flash1293 requested a review from a team as a code owner October 5, 2022 10:02
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks for fixing it

Testing log

  1. Switching between the setting
  2. Saving and refreshing with the setting
  3. Checking on dashboard
  4. Some crazy maximum number to see what'll happen, it looks very nice!

Screenshot 2022-10-05 at 13 48 16

@flash1293 flash1293 merged commit 322cadc into elastic:main Oct 5, 2022
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 5, 2022
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.5

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 5, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
(cherry picked from commit 322cadc)

Co-authored-by: Joe Reuter <[email protected]>
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Lens release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.5.0 v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lens] ticks on bands setting doesn't work for gauge
5 participants