Expression renderer: Make sure progress bar is visible #142699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash1293
added
release_note:fix
Team:AppServicesUx
backport:prev-minor
💚 Build Succeeded
Metrics [docs]Page load bundle
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/kibana-app-services (Team:AppServicesUx) |
botelastic
bot
added
the
Feature:ExpressionLanguage
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 6, 2022
(cherry picked from commit bf6a55d)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 6, 2022
(cherry picked from commit bf6a55d) Co-authored-by: Joe Reuter <[email protected]>
WafaaNasr
pushed a commit
to WafaaNasr/kibana
that referenced
this pull request
Oct 11, 2022
WafaaNasr
pushed a commit
to WafaaNasr/kibana
that referenced
this pull request
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #141912
If the visualization is using absolute positioning as well, the progress bar might be shown behind the chart itself (this happens for the new metric visualization which is using absolute positioning for the background.
This PR fixes this by lifting the progress bar to a higher z index. This does not break other absolutely positioned components like tooltips:
