Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIP] Support category pre-selection inside the FieldsBrowser component #142698

Merged
merged 1 commit into from
Oct 6, 2022
Merged

[TIP] Support category pre-selection inside the FieldsBrowser component #142698

merged 1 commit into from
Oct 6, 2022

Conversation

lgestc
Copy link
Contributor

@lgestc lgestc commented Oct 5, 2022 •
edited
Loading

Summary

This resolves https://github.com/elastic/security-team/issues/5007

How it looks like in the context of Threat Intelligence plugin:

156b5944-2539-4459-976f-caa142b56018.webm

You can see that the initial set of selected categories can be adjusted with the options property:

image

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@lgestc lgestc added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team: Protections Experience labels Oct 5, 2022
@lgestc lgestc requested a review from PhilippeOberti October 5, 2022 08:05
@lgestc lgestc requested review from a team as code owners October 5, 2022 08:05
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
threatIntelligence 113.1KB 113.2KB +33.0B
triggersActionsUi 672.7KB 672.8KB +151.0B
total +184.0B
Unknown metric groups

API count

id before after diff
triggersActionsUi 514 515 +1

History

  • 💔 Build #78218 failed 23ffcb6cdbb89466416521430ac5c28751537a0f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

jcger
jcger approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@jcger jcger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

PhilippeOberti
PhilippeOberti approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@PhilippeOberti PhilippeOberti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

YulNaumenko
YulNaumenko approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@lgestc lgestc merged commit 115039d into elastic:main Oct 6, 2022
@lgestc lgestc deleted the support-field-pre-selection branch October 6, 2022 07:01
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 11, 2022
@lgmys @WafaaNasr
[TIP] Support category pre-selection inside the FieldsBrowser compone…
d61bafa 
…nt (elastic#142698)

This resolves https://github.com/elastic/security-team/issues/5007
WafaaNasr pushed a commit to WafaaNasr/kibana that referenced this pull request Oct 14, 2022
@lgmys @WafaaNasr
[TIP] Support category pre-selection inside the FieldsBrowser compone…
5af8dd3 
…nt (elastic#142698)

This resolves https://github.com/elastic/security-team/issues/5007
@maxcold maxcold added release_note:enhancement Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. and removed release_note:skip Skip the PR/issue when compiling release notes labels Nov 10, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@nastasha-solomon nastasha-solomon mentioned this pull request Feb 13, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YulNaumenko YulNaumenko YulNaumenko approved these changes

@jcger jcger jcger approved these changes

@PhilippeOberti PhilippeOberti PhilippeOberti approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:enhancement Team: Protections Experience Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@lgestc @kibana-ci @elasticmachine @PhilippeOberti @jcger @YulNaumenko @maxcold @kibanamachine