[Fleet] fix abort agent singular #142696
Merged
[Fleet] fix abort agent singular #142696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliaElastic
added
release_note:skip
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
|
@elasticmachine merge upstream |
juliaElastic
commented
Oct 5, 2022
| @@ -34,7 +34,7 @@ export const useUpdateTags = () => { | |||
| const message = | |||
| successMessage ?? | |||
| i18n.translate('xpack.fleet.updateAgentTags.successNotificationTitle', { | |||
| defaultMessage: 'Tags updated', | |||
| defaultMessage: 'Tag(s) updated', | |||
There was a problem hiding this comment.
Fix #142182
updated toast message text to include singular and plural
💚 Build Succeeded
Metrics [docs]Async chunks
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 5, 2022
* fix abort agent singular * changed toast message to tag(s) updated Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit c46a624)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 5, 2022
* fix abort agent singular * changed toast message to tag(s) updated Co-authored-by: Kibana Machine <[email protected]> (cherry picked from commit c46a624) Co-authored-by: Julia Bardi <[email protected]>
WafaaNasr
pushed a commit
to WafaaNasr/kibana
that referenced
this pull request
Oct 11, 2022
* fix abort agent singular * changed toast message to tag(s) updated Co-authored-by: Kibana Machine <[email protected]>
WafaaNasr
pushed a commit
to WafaaNasr/kibana
that referenced
this pull request
Oct 14, 2022
* fix abort agent singular * changed toast message to tag(s) updated Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #142555
Fixed text on Abort upgrade modal, to show correctly for 1 agent:
This action will abort upgrade of 1 agentCovered with unit tests.
Fix #142182
updated toast message text to include singular and plural:
Tag(s) updatedChecklist