Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Explain Log Rate Spikes: fix chart showing as empty when filter matches field/value pair in hovered row #142693

Merged

Conversation

alvarezmelissa87
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 commented Oct 5, 2022

Summary

Related issue: #138975

This PR fixes the issue of the main histogram chart showing as empty when the search filter matches field/value pair in hovered the hovered row. The main histogram now reflects the mini histogram.

  • chart no longer shows as empty when there is data
  • dual brush not moving all the way to the left
  • brushes should not move on hover
    • this will be addressed in a follow up

Checklist

Delete any items that are not applicable to this PR.

@alvarezmelissa87 alvarezmelissa87 added release_note:fix :ml v8.5.0 Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis v8.6.0 labels Oct 5, 2022
@alvarezmelissa87 alvarezmelissa87 requested a review from a team as a code owner October 5, 2022 03:40
@alvarezmelissa87 alvarezmelissa87 self-assigned this Oct 5, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@alvarezmelissa87 alvarezmelissa87 changed the title fix chart showing as empty when filter matches field/value pair in hovered row [ML] Explain Log Rate Spikes: fix chart showing as empty when filter matches field/value pair in hovered row Oct 5, 2022
@alvarezmelissa87 alvarezmelissa87 force-pushed the ml-aiops-brush-chart-fix branch from ae6b60a to 4a1fe4a Compare October 5, 2022 19:47
@alvarezmelissa87 alvarezmelissa87 force-pushed the ml-aiops-brush-chart-fix branch 2 times, most recently from 0eb38b0 to b5d6a4b Compare October 11, 2022 16:39
@alvarezmelissa87 alvarezmelissa87 force-pushed the ml-aiops-brush-chart-fix branch from 098f2b0 to 0068ff5 Compare October 13, 2022 18:07
@peteharverson
Copy link
Contributor

Not related to the changes here, but did we work out why the mini histogram in the row is incorrect in cases like this, where the field / value matches the filter:

image

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Testing with partial-.ds-cluster-kibana-filebeat-* I can no longer reproduce the original issue.

@alvarezmelissa87
Copy link
Contributor Author

@elasticmachine merge upstream

@alvarezmelissa87
Copy link
Contributor Author

Not related to the changes here, but did we work out why the mini histogram in the row is incorrect in cases like this, where the field / value matches the filter:

image

Not yet - looking into it 👍

@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
aiops 766.6KB 766.9KB +217.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alvarezmelissa87

@walterra walterra added the bug Fixes for quality problems that affect the customer experience label Oct 18, 2022
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code & test LGTM. Sounds good to pick up additional fixes in follow ups and get this in.

Noticed the following:

image

When there's no "overall" data at all, we might still want to create a time series with all zeroes and pass it on to the chart. Otherwise we end up with a tooltip that's not showing a 0 for overall data.

@alvarezmelissa87 alvarezmelissa87 merged commit 253ed9c into elastic:main Oct 18, 2022
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Oct 18, 2022
@alvarezmelissa87 alvarezmelissa87 deleted the ml-aiops-brush-chart-fix branch October 18, 2022 17:44
kc13greiner pushed a commit to kc13greiner/kibana that referenced this pull request Oct 18, 2022
…matches field/value pair in hovered row (elastic#142693)

* fix chart showing as empty when filter matches field/value pair in hovered row

* use both overall and split buckets to get timerange

* always pass along split stats as they are up to date

Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting bug Fixes for quality problems that affect the customer experience Feature:ML/AIOps ML AIOps features: Change Point Detection, Log Pattern Analysis, Log Rate Analysis :ml release_note:fix v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants