-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Explain Log Rate Spikes: fix chart showing as empty when filter matches field/value pair in hovered row #142693
[ML] Explain Log Rate Spikes: fix chart showing as empty when filter matches field/value pair in hovered row #142693
Conversation
Pinging @elastic/ml-ui (:ml) |
ae6b60a
to
4a1fe4a
Compare
0eb38b0
to
b5d6a4b
Compare
098f2b0
to
0068ff5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Testing with partial-.ds-cluster-kibana-filebeat-*
I can no longer reproduce the original issue.
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code & test LGTM. Sounds good to pick up additional fixes in follow ups and get this in.
Noticed the following:
When there's no "overall" data at all, we might still want to create a time series with all zeroes and pass it on to the chart. Otherwise we end up with a tooltip that's not showing a 0 for overall data.
…matches field/value pair in hovered row (elastic#142693) * fix chart showing as empty when filter matches field/value pair in hovered row * use both overall and split buckets to get timerange * always pass along split stats as they are up to date Co-authored-by: Kibana Machine <[email protected]>
Summary
Related issue: #138975
This PR fixes the issue of the main histogram chart showing as empty when the search filter matches field/value pair in hovered the hovered row. The main histogram now reflects the mini histogram.
Checklist
Delete any items that are not applicable to this PR.